aboutsummaryrefslogtreecommitdiffstats
path: root/bot
diff options
context:
space:
mode:
authorGravatar Chris Lovering <[email protected]>2021-12-28 22:20:01 +0000
committerGravatar Chris Lovering <[email protected]>2021-12-28 22:20:18 +0000
commitd55cbc8e4ed371f0ca11b97b1dd6e41cf8f6719c (patch)
treeb3fa1b7aecaedc23edb572d49d69485059524159 /bot
parentAbility to block users from AoC completer role (diff)
Condense conditional logic in AoC completionist role task
Diffstat (limited to 'bot')
-rw-r--r--bot/exts/events/advent_of_code/_cog.py11
1 files changed, 3 insertions, 8 deletions
diff --git a/bot/exts/events/advent_of_code/_cog.py b/bot/exts/events/advent_of_code/_cog.py
index 67d43556..9d412adf 100644
--- a/bot/exts/events/advent_of_code/_cog.py
+++ b/bot/exts/events/advent_of_code/_cog.py
@@ -100,16 +100,11 @@ class AdventOfCode(commands.Cog):
continue
member = await members.get_or_fetch_member(guild, member_id)
- if member is None:
+ if member is None or completionist_role in member.roles:
continue
- if completionist_role in member.roles:
- continue
-
- if await self.completionist_block_list.contains(member_id):
- continue
-
- await members.handle_role_change(member, member.add_roles, completionist_role)
+ if not await self.completionist_block_list.contains(member_id):
+ await members.handle_role_change(member, member.add_roles, completionist_role)
@commands.group(name="adventofcode", aliases=("aoc",))
@whitelist_override(channels=AOC_WHITELIST)