From d55cbc8e4ed371f0ca11b97b1dd6e41cf8f6719c Mon Sep 17 00:00:00 2001 From: Chris Lovering Date: Tue, 28 Dec 2021 22:20:01 +0000 Subject: Condense conditional logic in AoC completionist role task --- bot/exts/events/advent_of_code/_cog.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'bot') diff --git a/bot/exts/events/advent_of_code/_cog.py b/bot/exts/events/advent_of_code/_cog.py index 67d43556..9d412adf 100644 --- a/bot/exts/events/advent_of_code/_cog.py +++ b/bot/exts/events/advent_of_code/_cog.py @@ -100,16 +100,11 @@ class AdventOfCode(commands.Cog): continue member = await members.get_or_fetch_member(guild, member_id) - if member is None: + if member is None or completionist_role in member.roles: continue - if completionist_role in member.roles: - continue - - if await self.completionist_block_list.contains(member_id): - continue - - await members.handle_role_change(member, member.add_roles, completionist_role) + if not await self.completionist_block_list.contains(member_id): + await members.handle_role_change(member, member.add_roles, completionist_role) @commands.group(name="adventofcode", aliases=("aoc",)) @whitelist_override(channels=AOC_WHITELIST) -- cgit v1.2.3