aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Numerlor <[email protected]>2020-07-25 03:13:20 +0200
committerGravatar Numerlor <[email protected]>2020-07-25 03:13:49 +0200
commit7e367ce4a5df3fbd768c6dce1acc39e786a376ea (patch)
tree88e6795cd3ec889f409e912e4ee785d98f0f10f2
parentChange ValidPythonIdentifier tests to PackageName. (diff)
Ensure all renamed symbols are kept
After the restructure behaviour change in d790c404ca3dba3843f351d6f42e766956aa73a1, the add to renamed_symbols was not readded and symbols that only passed the first check were being missed.
-rw-r--r--bot/cogs/doc/cog.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/bot/cogs/doc/cog.py b/bot/cogs/doc/cog.py
index bd27dde01..e52ee95c1 100644
--- a/bot/cogs/doc/cog.py
+++ b/bot/cogs/doc/cog.py
@@ -148,6 +148,7 @@ class DocCog(commands.Cog):
or any(package in symbol_base_url for package in NO_OVERRIDE_PACKAGES)
):
symbol = f"{group_name}.{symbol}"
+ self.renamed_symbols.add(symbol)
elif (overridden_symbol_group := self.doc_symbols[symbol].group) in NO_OVERRIDE_GROUPS:
overridden_symbol = f"{overridden_symbol_group}.{symbol}"
@@ -158,7 +159,7 @@ class DocCog(commands.Cog):
self.renamed_symbols.add(overridden_symbol)
# If renamed `symbol` already exists, add library name in front to differentiate between them.
- if symbol in self.renamed_symbols:
+ elif symbol in self.renamed_symbols:
# Split `package_name` because of packages like Pillow that have spaces in them.
symbol = f"{api_package_name}.{symbol}"
self.renamed_symbols.add(symbol)