From 7e367ce4a5df3fbd768c6dce1acc39e786a376ea Mon Sep 17 00:00:00 2001 From: Numerlor <25886452+Numerlor@users.noreply.github.com> Date: Sat, 25 Jul 2020 03:13:20 +0200 Subject: Ensure all renamed symbols are kept After the restructure behaviour change in d790c404ca3dba3843f351d6f42e766956aa73a1, the add to renamed_symbols was not readded and symbols that only passed the first check were being missed. --- bot/cogs/doc/cog.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bot/cogs/doc/cog.py b/bot/cogs/doc/cog.py index bd27dde01..e52ee95c1 100644 --- a/bot/cogs/doc/cog.py +++ b/bot/cogs/doc/cog.py @@ -148,6 +148,7 @@ class DocCog(commands.Cog): or any(package in symbol_base_url for package in NO_OVERRIDE_PACKAGES) ): symbol = f"{group_name}.{symbol}" + self.renamed_symbols.add(symbol) elif (overridden_symbol_group := self.doc_symbols[symbol].group) in NO_OVERRIDE_GROUPS: overridden_symbol = f"{overridden_symbol_group}.{symbol}" @@ -158,7 +159,7 @@ class DocCog(commands.Cog): self.renamed_symbols.add(overridden_symbol) # If renamed `symbol` already exists, add library name in front to differentiate between them. - if symbol in self.renamed_symbols: + elif symbol in self.renamed_symbols: # Split `package_name` because of packages like Pillow that have spaces in them. symbol = f"{api_package_name}.{symbol}" self.renamed_symbols.add(symbol) -- cgit v1.2.3