diff options
| author |  Cam Caswell <[email protected]> | 2022-05-08 12:33:59 -0400 |
|---|---|---|
| committer | Cam Caswell <[email protected]> | 2022-05-08 12:33:59 -0400 |
| commit | 2470557cb6f4ce9eb10bdf1759f67b03e1506b6e (patch) | |
| tree | c0b858944aa4cc04b73b2436eb8d07e4335dfeda /pydis_site/apps/content | |
| parent | Add note that staff members can create feature branches (diff) | |
Add Making Changes step
Diffstat (limited to 'pydis_site/apps/content')
| -rw-r--r-- | pydis_site/apps/content/resources/guides/pydis-guides/contributing.md | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/pydis_site/apps/content/resources/guides/pydis-guides/contributing.md b/pydis_site/apps/content/resources/guides/pydis-guides/contributing.md index d67a827f..6231fe87 100644 --- a/pydis_site/apps/content/resources/guides/pydis-guides/contributing.md +++ b/pydis_site/apps/content/resources/guides/pydis-guides/contributing.md @@ -126,7 +126,12 @@ The first step to any new contribution is an issue describing a problem with the Don't move forward until your issue is approved by a Core Developer. Issues are not guaranteed to be approved so your work may be wasted. {: .notification .is-warning } -### 5. Open a pull request +### 5. Make changes +Now it is time to make the changes to fulfill your approved issue. You should create a new Git branch for your feature; that way you can keep your main branch up to date with ours and even work on multiple features at once in separate branches. + +This is a good time to review [how to write good commit messages](./contributing-guidelines/commit-messages) if you haven't already. + +### 6. Open a pull request After your issue has been approved and you've written your code and tested it, it's time to open a pull request. Pull requests are a feature in GitHub; you can think of them as asking the project maintainers to accept your changes. This gives other contributors a chance to review your code and make any needed changes before it's merged into the main branch of the project. Check out our [**Pull Request Guide**](./pull-requests/) for help with opening a pull request and going through the review process. |