Add validation to filters to not allow duplicated channels and categories

1 files changed, 29 insertions, 0 deletions

diff --git a/pydis_site/apps/api/models/bot/filters.py b/pydis_site/apps/api/models/bot/filters.py
index eebcf703..45dea2c4 100644
--- a/pydis_site/apps/api/models/bot/filters.py
+++ b/pydis_site/apps/api/models/bot/filters.py
@@ -112,6 +112,20 @@ class FilterList(FilterSettingsMixin):
     allowed_channels = ArrayField(models.IntegerField())
     allowed_categories = ArrayField(models.IntegerField())
 
+    def clean(self):
+        """Do not allow duplicates in allowed and disallowed lists."""
+        # Still run infraction fields validation
+        super().clean()
+
+        channels_collection = self.allowed_channels + self.disallowed_channels
+        categories_collection = self.allowed_categories + self.disallowed_categories
+
+        if len(channels_collection) != len(set(channels_collection)):
+            raise ValidationError("Allowed and disallowed channels lists contain duplicates.")
+
+        if len(categories_collection) != len(set(categories_collection)):
+            raise ValidationError("Allowed and disallowed categories lists contain duplicates.")
+
     class Meta:
         """Constrain name and list_type unique."""
 
@@ -166,5 +180,20 @@ class Filter(FilterSettingsMixin):
     allowed_channels = ArrayField(models.IntegerField(), null=True)
     allowed_categories = ArrayField(models.IntegerField(), null=True)
 
+    def clean(self):
+        """Do not allow duplicates in allowed and disallowed lists."""
+        # Still run infraction fields validation
+        super().clean()
+
+        if self.allowed_channels is not None or self.disallowed_channels is not None:
+            channels_collection = self.allowed_channels + self.disallowed_channels
+            if len(channels_collection) != len(set(channels_collection)):
+                raise ValidationError("Allowed and disallowed channels lists contain duplicates.")
+
+        if self.allowed_categories is not None or self.disallowed_categories is not None:
+            categories_collection = self.allowed_categories + self.disallowed_categories
+            if len(categories_collection) != len(set(categories_collection)):
+                raise ValidationError("Allowed and disallowed categories lists contain duplicates.")
+
     def __str__(self) -> str:
         return f"Filter {self.content!r}"