aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar rohanjnr <[email protected]>2020-08-26 22:19:24 +0530
committerGravatar rohanjnr <[email protected]>2020-08-26 22:19:24 +0530
commit792af719e7934e639535e8803e7cd0118ccf43fb (patch)
tree4a78982bbbe98b63e76c7b4088cd748a0a0d5b7e
parentadd support for bulk updates on user model (diff)
Add reference links in UserListSerializer methods
-rw-r--r--pydis_site/apps/api/serializers.py9
1 files changed, 7 insertions, 2 deletions
diff --git a/pydis_site/apps/api/serializers.py b/pydis_site/apps/api/serializers.py
index 757faeae..6146584b 100644
--- a/pydis_site/apps/api/serializers.py
+++ b/pydis_site/apps/api/serializers.py
@@ -275,6 +275,8 @@ class UserListSerializer(ListSerializer):
"""
Overriding `to_internal_value` function with a few changes to support bulk updates.
+ ref: https://github.com/miki725/django-rest-framework-bulk/issues/68
+
List of dicts of native values <- List of dicts of primitive datatypes.
"""
if html.is_html_input(data):
@@ -299,7 +301,6 @@ class UserListSerializer(ListSerializer):
for item in data:
# inserted code
- # bug: https://github.com/miki725/django-rest-framework-bulk/issues/68
# -----------------
try:
self.child.instance = self.instance.get(id=item['id'])
@@ -321,7 +322,11 @@ class UserListSerializer(ListSerializer):
return ret
def update(self, instance: QuerySet, validated_data: list) -> list:
- """Override update method to support bulk updates."""
+ """
+ Override update method to support bulk updates.
+
+ ref:https://www.django-rest-framework.org/api-guide/serializers/#customizing-multiple-update
+ """
instance_mapping = {user.id: user for user in instance}
data_mapping = {item['id']: item for item in validated_data}