diff options
| author |  Gareth Coles <[email protected]> | 2019-10-11 19:41:19 +0100 |
|---|---|---|
| committer | Gareth Coles <[email protected]> | 2019-10-11 19:41:19 +0100 |
| commit | 404a9a7f7fd0be92cb6c2c732668512a8e2016f9 (patch) | |
| tree | fed2b992580bb17bafe69dc786ee0e26f44f2aad | |
| parent | Simplify signals.py as per @jchristgit's review (diff) | |
Clean up signal tests as per @jchristgit's review
| -rw-r--r-- | pydis_site/apps/home/tests/test_signal_listener.py | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/pydis_site/apps/home/tests/test_signal_listener.py b/pydis_site/apps/home/tests/test_signal_listener.py index c79a0294..b7ad4d6e 100644 --- a/pydis_site/apps/home/tests/test_signal_listener.py +++ b/pydis_site/apps/home/tests/test_signal_listener.py @@ -271,7 +271,7 @@ class SignalListenerTests(TestCase): """Test application of groups by role, relating to an admin user.""" handler = SignalListener() - self.assertTrue(self.django_user_discordless.groups.all().count() == 0) + self.assertEqual(self.django_user_discordless.groups.all().count(), 0) # Apply groups based on admin role being present on Discord handler._apply_groups(self.discord_admin, self.social_admin) @@ -279,7 +279,7 @@ class SignalListenerTests(TestCase): # Remove groups based on the user apparently leaving the server handler._apply_groups(self.discord_admin, self.social_admin, True) - self.assertTrue(self.django_user_discordless.groups.all().count() == 0) + self.assertEqual(self.django_user_discordless.groups.all().count(), 0) # Apply the admin role again handler._apply_groups(self.discord_admin, self.social_admin) @@ -289,7 +289,7 @@ class SignalListenerTests(TestCase): # Remove groups based on the user no longer having the admin role on Discord handler._apply_groups(self.discord_admin, self.social_admin) - self.assertTrue(self.django_user_discordless.groups.all().count() == 0) + self.assertEqual(self.django_user_discordless.groups.all().count(), 0) self.discord_admin.roles.add(self.admin_role) self.discord_admin.save() @@ -298,22 +298,23 @@ class SignalListenerTests(TestCase): """Test application of groups by role, relating to non-standard cases.""" handler = SignalListener() - self.assertTrue(self.django_user_discordless.groups.all().count() == 0) + self.assertEqual(self.django_user_discordless.groups.all().count(), 0) # No groups should be applied when there's no user account yet handler._apply_groups(self.discord_unmapped, self.social_unmapped) - self.assertTrue(self.django_user_discordless.groups.all().count() == 0) + self.assertEqual(self.django_user_discordless.groups.all().count(), 0) # No groups should be applied when there are only unmapped roles to match handler._apply_groups(self.discord_unmapped, self.social_user) - self.assertTrue(self.django_user.groups.all().count() == 0) + self.assertEqual(self.django_user.groups.all().count(), 0) # No groups should be applied when the user isn't in the guild handler._apply_groups(self.discord_not_in_guild, self.social_user) - self.assertTrue(self.django_user.groups.all().count() == 0) + self.assertEqual(self.django_user.groups.all().count(), 0) def test_role_mapping_str(self): """Test that role mappings stringify correctly.""" - self.assertTrue( - str(self.role_mapping) == f"@{self.admin_role.name} -> {self.admin_group.name}" + self.assertEqual( + str(self.role_mapping), + f"@{self.admin_role.name} -> {self.admin_group.name}" ) |