General improvements

Fix typo in docstring, change logic for creating message to be smarter, change CoinSide converter logic to be smarter

1 files changed, 6 insertions, 9 deletions

diff --git a/bot/exts/evergreen/coinflip.py b/bot/exts/evergreen/coinflip.py
index c0aa5645..3a2ece03 100644
--- a/bot/exts/evergreen/coinflip.py
+++ b/bot/exts/evergreen/coinflip.py
@@ -18,11 +18,10 @@ class CoinSide(commands.Converter):
         if side in CoinSide.HEADS:
             return "heads"
 
-        elif side in CoinSide.TAILS:
+        if side in CoinSide.TAILS:
             return "tails"
 
-        else:
-            raise commands.BadArgument(f"{side!r} is not a valid coin side.")
+        raise commands.BadArgument(f"{side!r} is not a valid coin side.")
 
 
 class CoinFlip(commands.Cog):
@@ -33,16 +32,14 @@ class CoinFlip(commands.Cog):
         """
         Flips a coin.
 
-        If `coin_side` is provided will state whether you guessed the side correctly.
+        If `side` is provided will state whether you guessed the side correctly.
         """
         flipped_side = random.choice(["heads", "tails"])
 
-        if not side:
-            await ctx.send(f"{ctx.author.mention} flipped **{flipped_side}**!")
-            return
-
         message = f"{ctx.author.mention} flipped **{flipped_side}**. "
-        if side == flipped_side:
+        if not side:
+            await ctx.send(message)
+        elif side == flipped_side:
             message += f"You guessed correctly! {Emojis.lemon_hyperpleased}"
         else:
             message += f"You guessed incorrectly. {Emojis.lemon_pensive}"