Deseasonify: log in `add_cog` rather than in each `setup`

The previous system required each extension's `setup` func to log
that the cog was loaded. This leads to inconsistent messages all
trying to convey the same thing, variable logger names in the output
file are difficult to read, and several extensions were not logging
at all.

By logging directly in the `add_cog` method, we reduce code repetition,
ensure consistent format, and remove the responsibility to remember
that a log should be made.

16 files changed, 0 insertions, 17 deletions

diff --git a/bot/exts/evergreen/battleship.py b/bot/exts/evergreen/battleship.py
index 9b8aaa48..9bc374e6 100644
--- a/bot/exts/evergreen/battleship.py
+++ b/bot/exts/evergreen/battleship.py
@@ -441,4 +441,3 @@ class Battleship(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Cog load."""
     bot.add_cog(Battleship(bot))
-    log.info("Battleship cog loaded")
diff --git a/bot/exts/evergreen/bookmark.py b/bot/exts/evergreen/bookmark.py
index e703e07b..73908702 100644
--- a/bot/exts/evergreen/bookmark.py
+++ b/bot/exts/evergreen/bookmark.py
@@ -62,4 +62,3 @@ class Bookmark(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Load the Bookmark cog."""
     bot.add_cog(Bookmark(bot))
-    log.info("Bookmark cog loaded")
diff --git a/bot/exts/evergreen/branding.py b/bot/exts/evergreen/branding.py
index 2eb563ea..0a14cd84 100644
--- a/bot/exts/evergreen/branding.py
+++ b/bot/exts/evergreen/branding.py
@@ -501,4 +501,3 @@ class BrandingManager(commands.Cog):
 def setup(bot: SeasonalBot) -> None:
     """Load BrandingManager cog."""
     bot.add_cog(BrandingManager(bot))
-    log.info("BrandingManager cog loaded")
diff --git a/bot/exts/evergreen/error_handler.py b/bot/exts/evergreen/error_handler.py
index f756c321..33b1a3f2 100644
--- a/bot/exts/evergreen/error_handler.py
+++ b/bot/exts/evergreen/error_handler.py
@@ -127,4 +127,3 @@ class CommandErrorHandler(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Error handler Cog load."""
     bot.add_cog(CommandErrorHandler(bot))
-    log.info("CommandErrorHandler cog loaded")
diff --git a/bot/exts/evergreen/fun.py b/bot/exts/evergreen/fun.py
index 889ae079..67a4bae5 100644
--- a/bot/exts/evergreen/fun.py
+++ b/bot/exts/evergreen/fun.py
@@ -145,4 +145,3 @@ class Fun(Cog):
 def setup(bot: commands.Bot) -> None:
     """Fun Cog load."""
     bot.add_cog(Fun(bot))
-    log.info("Fun cog loaded")
diff --git a/bot/exts/evergreen/help.py b/bot/exts/evergreen/help.py
index f4d76402..ccd76d76 100644
--- a/bot/exts/evergreen/help.py
+++ b/bot/exts/evergreen/help.py
@@ -540,8 +540,6 @@ def setup(bot: SeasonalBot) -> None:
     except Exception:
         unload(bot)
         raise
-    else:
-        log.info("Help cog loaded")
 
 
 def teardown(bot: SeasonalBot) -> None:
diff --git a/bot/exts/evergreen/issues.py b/bot/exts/evergreen/issues.py
index fb18b62a..4129156a 100644
--- a/bot/exts/evergreen/issues.py
+++ b/bot/exts/evergreen/issues.py
@@ -74,4 +74,3 @@ class Issues(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Cog Retrieves Issues From Github."""
     bot.add_cog(Issues(bot))
-    log.info("Issues cog loaded")
diff --git a/bot/exts/evergreen/magic_8ball.py b/bot/exts/evergreen/magic_8ball.py
index e47ef454..c10f1f51 100644
--- a/bot/exts/evergreen/magic_8ball.py
+++ b/bot/exts/evergreen/magic_8ball.py
@@ -29,4 +29,3 @@ class Magic8ball(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Magic 8ball Cog load."""
     bot.add_cog(Magic8ball(bot))
-    log.info("Magic8ball cog loaded")
diff --git a/bot/exts/evergreen/minesweeper.py b/bot/exts/evergreen/minesweeper.py
index b0ba8145..b59cdb14 100644
--- a/bot/exts/evergreen/minesweeper.py
+++ b/bot/exts/evergreen/minesweeper.py
@@ -282,4 +282,3 @@ class Minesweeper(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Load the Minesweeper cog."""
     bot.add_cog(Minesweeper(bot))
-    log.info("Minesweeper cog loaded")
diff --git a/bot/exts/evergreen/recommend_game.py b/bot/exts/evergreen/recommend_game.py
index 835a4e53..7cd52c2c 100644
--- a/bot/exts/evergreen/recommend_game.py
+++ b/bot/exts/evergreen/recommend_game.py
@@ -48,4 +48,3 @@ class RecommendGame(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Loads the RecommendGame cog."""
     bot.add_cog(RecommendGame(bot))
-    log.info("RecommendGame cog loaded")
diff --git a/bot/exts/evergreen/reddit.py b/bot/exts/evergreen/reddit.py
index a07e591f..fe204419 100644
--- a/bot/exts/evergreen/reddit.py
+++ b/bot/exts/evergreen/reddit.py
@@ -126,4 +126,3 @@ class Reddit(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Load the Cog."""
     bot.add_cog(Reddit(bot))
-    log.debug('Loaded')
diff --git a/bot/exts/evergreen/showprojects.py b/bot/exts/evergreen/showprojects.py
index a943e548..328a7aa5 100644
--- a/bot/exts/evergreen/showprojects.py
+++ b/bot/exts/evergreen/showprojects.py
@@ -31,4 +31,3 @@ class ShowProjects(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Show Projects Reaction Cog."""
     bot.add_cog(ShowProjects(bot))
-    log.info("ShowProjects cog loaded")
diff --git a/bot/exts/evergreen/snakes/__init__.py b/bot/exts/evergreen/snakes/__init__.py
index 06ebfb47..2eae2751 100644
--- a/bot/exts/evergreen/snakes/__init__.py
+++ b/bot/exts/evergreen/snakes/__init__.py
@@ -10,4 +10,3 @@ log = logging.getLogger(__name__)
 def setup(bot: commands.Bot) -> None:
     """Snakes Cog load."""
     bot.add_cog(Snakes(bot))
-    log.info("Snakes cog loaded")
diff --git a/bot/exts/evergreen/speedrun.py b/bot/exts/evergreen/speedrun.py
index 76c5e8d3..4e8d7aee 100644
--- a/bot/exts/evergreen/speedrun.py
+++ b/bot/exts/evergreen/speedrun.py
@@ -25,4 +25,3 @@ class Speedrun(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Load the Speedrun cog."""
     bot.add_cog(Speedrun(bot))
-    log.info("Speedrun cog loaded")
diff --git a/bot/exts/evergreen/trivia_quiz.py b/bot/exts/evergreen/trivia_quiz.py
index 99b64497..c1a271e8 100644
--- a/bot/exts/evergreen/trivia_quiz.py
+++ b/bot/exts/evergreen/trivia_quiz.py
@@ -300,4 +300,3 @@ class TriviaQuiz(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Load the cog."""
     bot.add_cog(TriviaQuiz(bot))
-    logger.debug("TriviaQuiz cog loaded")
diff --git a/bot/exts/evergreen/uptime.py b/bot/exts/evergreen/uptime.py
index 6f24f545..a9ad9dfb 100644
--- a/bot/exts/evergreen/uptime.py
+++ b/bot/exts/evergreen/uptime.py
@@ -31,4 +31,3 @@ class Uptime(commands.Cog):
 def setup(bot: commands.Bot) -> None:
     """Uptime Cog load."""
     bot.add_cog(Uptime(bot))
-    log.info("Uptime cog loaded")