diff options
| author |  Shivansh <[email protected]> | 2021-04-30 07:22:27 +0530 |
|---|---|---|
| committer | Shivansh <[email protected]> | 2021-04-30 07:22:27 +0530 |
| commit | f6d8a3f39d1a480e64ac322291cbf7820c00d3b0 (patch) | |
| tree | 84161b5c0d2d9d6cf86e0819ed48ef19b7aa7cb0 | |
| parent | Give more information in function doc-strings (diff) | |
Remove redundant code
The entire `name_verifier` function can be replaced with just a dict.get
| -rw-r--r-- | bot/exts/pride/pride_leader.py | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/bot/exts/pride/pride_leader.py b/bot/exts/pride/pride_leader.py index 5ecfd2ea..83b3ac0e 100644 --- a/bot/exts/pride/pride_leader.py +++ b/bot/exts/pride/pride_leader.py @@ -25,13 +25,6 @@ class PrideLeader(commands.Cog): with PRIDE_LEADERS_RESOURCE.open(encoding="utf8") as data: self.pride = json.load(data) - def name_verifier(self, leader_name: str) -> Optional[str]: - """Verify leader name whether it is present in resources or not.""" - leader_name = leader_name.title() - if leader_name in self.pride: - return leader_name - log.trace(f"Got a Invalid pride leader: {leader_name}") - def invalid_embed_generate(self, pride_leader: str) -> discord.Embed: """ Generates Invalid Embed. @@ -112,8 +105,10 @@ class PrideLeader(commands.Cog): if not pride_leader_name: leader = random.choice([name for name in self.pride]) else: - leader = self.name_verifier(pride_leader_name) + leader = self.pride.get(pride_leader_name.title()) if not leader: + log.trace(f"Got a Invalid pride leader: {pride_leader_name}") + embed = self.invalid_embed_generate(pride_leader_name) await ctx.send(embed=embed) return |