diff options
| author |  Shivansh <[email protected]> | 2021-05-18 11:01:59 +0530 |
|---|---|---|
| committer | Shivansh <[email protected]> | 2021-05-18 11:01:59 +0530 |
| commit | dd01caf0393386998f9c121ccb1c108057c03f77 (patch) | |
| tree | 316927f1ad32beb44c719f5ef1ece6db9ab3e859 | |
| parent | Change bot typehint to bot.bot.Bot (diff) | |
Apply code review suggestions
* Use read_text rather a with open
* Remove Redundant list comprehension
| -rw-r--r-- | bot/exts/pride/pride_leader.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/bot/exts/pride/pride_leader.py b/bot/exts/pride/pride_leader.py index 0e1ddb20..95ca74e4 100644 --- a/bot/exts/pride/pride_leader.py +++ b/bot/exts/pride/pride_leader.py @@ -23,8 +23,7 @@ class PrideLeader(commands.Cog): def __init__(self, bot: bot.Bot): self.bot = bot - with PRIDE_LEADERS_RESOURCE.open(encoding="utf8") as data: - self.pride = json.load(data) + self.pride = json.loads(PRIDE_LEADERS_RESOURCE.read_text("utf8")) def invalid_embed_generate(self, pride_leader: str) -> discord.Embed: """ @@ -104,7 +103,7 @@ class PrideLeader(commands.Cog): and if there is no pride leader given, return a random pride leader. """ if not pride_leader_name: - leader = random.choice([name for name in self.pride]) + leader = random.choice(list(self.pride)) else: leader = self.pride.get(pride_leader_name.title()) if not leader: |