diff options
| author |  Xithrius <[email protected]> | 2021-04-24 01:47:17 -0700 |
|---|---|---|
| committer |  GitHub <[email protected]> | 2021-04-24 01:47:17 -0700 |
| commit | c132ecf666697344e1d478d57df63bdcb3591b88 (patch) | |
| tree | ef3598290b0c6878704e2565f117f29cb6fe12cd | |
| parent | Merge pull request #702 from python-discord/fix-reddit-index-error (diff) | |
| parent | Merge branch 'main' into update-pr-template (diff) | |
Merge pull request #700 from python-discord/update-pr-template
Reword PR Template
| -rw-r--r-- | .github/pull_request_template.md | 30 |
1 files changed, 10 insertions, 20 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e2739287..fade00e1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,30 +1,20 @@ ## Relevant Issues -<!-- List relevant issue tickets here. --> -<!-- Say "Closes #0" for issues that the PR resolves, replacing 0 with the issue number. --> +<!-- +It is mandatory to link to an issue that has been approved by a Core Developer, indicated by an "approved" label. +Issues can be skipped with explicit core dev approval, but you have to link the discussion. +--> - -## Description -<!-- Describe how you've implemented your changes. --> - - -## Reasoning -<!-- Outline the reasoning for how it's been implemented. --> +<!-- Link the issue by typing: "Closes #<number>" (Closes #0 to close issue 0 for example). --> -## Screenshots -<!-- Remove this section if the changes don't impact anything user-facing. --> -<!-- You can add images by just copy pasting them directly in the editor. --> - - -## Additional Details -<!-- Delete this section if not applicable. --> - +## Description +<!-- Describe what changes you made, and how you've implemented them. --> ## Did you: <!-- These are required when contributing. --> <!-- Replace [ ] with [x] to mark items as done. --> - [ ] Join the [**Python Discord Community**](https://discord.gg/python)? -- [ ] If dependencies have been added or updated, run `pipenv lock`? -- [ ] **Lint your code** (`pipenv run lint`)? -- [ ] Set the PR to **allow edits from contributors**? +- [ ] Read all the comments in this tempelate? +- [ ] Ensure there is an issue open, or link relevant discord discussions? +- [ ] Read the [contributing guidelines](https://pythondiscord.com/pages/contributing/contributing-guidelines/)? |