aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Izan <[email protected]>2022-10-02 15:35:15 +0100
committerGravatar Izan <[email protected]>2022-10-02 15:35:15 +0100
commit5f5523ff34277575bdbc755140cfa10c61adc546 (patch)
treef5371b7a5eb494405cb078193086e17e8a399c27
parentMerge pull request #1110 from python-discord/fix-issue-1106 (diff)
Correct logic in `format_embed`.
-rw-r--r--bot/exts/events/hacktoberfest/hacktober-issue-finder.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/bot/exts/events/hacktoberfest/hacktober-issue-finder.py b/bot/exts/events/hacktoberfest/hacktober-issue-finder.py
index 8be985f9..aeffc8d7 100644
--- a/bot/exts/events/hacktoberfest/hacktober-issue-finder.py
+++ b/bot/exts/events/hacktoberfest/hacktober-issue-finder.py
@@ -100,8 +100,9 @@ class HacktoberIssues(commands.Cog):
"""Format the issue data into a embed."""
title = issue["title"]
issue_url = issue["url"].replace("api.", "").replace("/repos/", "/")
- # issues can have empty bodies, which in that case GitHub doesn't include the key in the API response
- body = issue.get("body", "")
+ # Issues can have empty bodies, resulting in the value being a literal `null` (parsed as `None`).
+ # For this reason, we can't use the default arg of `dict.get`, and so instead use `or` logic.
+ body = issue.get("body") or ""
labels = [label["name"] for label in issue["labels"]]
embed = discord.Embed(title=title)