diff options
| author |  Hassan Abouelela <[email protected]> | 2021-04-22 02:06:47 +0300 |
|---|---|---|
| committer | Hassan Abouelela <[email protected]> | 2021-04-22 02:13:13 +0300 |
| commit | 4cc5b4432ff6955b405099bf42e89d942c518698 (patch) | |
| tree | 6f73b35b02ad1c6bf398a5072ef0383bb072841a | |
| parent | Merge pull request #697 from ToxicKidz/fix_catify (diff) | |
Rewords PR Template
This is a rewording of the comments in the PR template, to hopefully clarify intentions.
It also removes unneeded fields.
Signed-off-by: Hassan Abouelela <[email protected]>
| -rw-r--r-- | .github/pull_request_template.md | 30 |
1 files changed, 10 insertions, 20 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e2739287..2bb274de 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,30 +1,20 @@ ## Relevant Issues -<!-- List relevant issue tickets here. --> -<!-- Say "Closes #0" for issues that the PR resolves, replacing 0 with the issue number. --> +<!-- +Linking an issue approved by a Core Developer, which will have the "approved" label, is mandatory. +Issues can be skipped with explicit core dev approval, but you have to link the discussion. +--> - -## Description -<!-- Describe how you've implemented your changes. --> - - -## Reasoning -<!-- Outline the reasoning for how it's been implemented. --> +<!-- Link the issue by typing: "Closes #<number>" (Closes #0 to close issue 0 for example). --> -## Screenshots -<!-- Remove this section if the changes don't impact anything user-facing. --> -<!-- You can add images by just copy pasting them directly in the editor. --> - - -## Additional Details -<!-- Delete this section if not applicable. --> - +## Description +<!-- Describe what changes you made, and how you've implemented them. --> ## Did you: <!-- These are required when contributing. --> <!-- Replace [ ] with [x] to mark items as done. --> - [ ] Join the [**Python Discord Community**](https://discord.gg/python)? -- [ ] If dependencies have been added or updated, run `pipenv lock`? -- [ ] **Lint your code** (`pipenv run lint`)? -- [ ] Set the PR to **allow edits from contributors**? +- [ ] Read all the comments in this tempelate. +- [ ] Ensure there is an issue open, or link relevant discord discussions. +- [ ] Read the [contributing guidelines](https://pythondiscord.com/pages/contributing/contributing-guidelines/). |