diff options
| author |  ChrisJL <[email protected]> | 2021-12-29 13:54:51 +0000 |
|---|---|---|
| committer |  GitHub <[email protected]> | 2021-12-29 13:54:51 +0000 |
| commit | 2d03a0f3e747174a38614a5b50f9cd6fba34d322 (patch) | |
| tree | ad07a6a449a322165d7246699908256c2df7a047 | |
| parent | Merge pull request #991 from python-discord/aoc-completer-role (diff) | |
| parent | Raise error when bot can't modify the given role in member helper util (diff) | |
Merge pull request #994 from python-discord/logging-in-AoC-completer-task
Add logging to aoc completer task
| -rw-r--r-- | bot/exts/events/advent_of_code/_cog.py | 11 | ||||
| -rw-r--r-- | bot/utils/members.py | 2 |
2 files changed, 10 insertions, 3 deletions
diff --git a/bot/exts/events/advent_of_code/_cog.py b/bot/exts/events/advent_of_code/_cog.py index 30bcaae6..c597fd0e 100644 --- a/bot/exts/events/advent_of_code/_cog.py +++ b/bot/exts/events/advent_of_code/_cog.py @@ -74,7 +74,7 @@ class AdventOfCode(commands.Cog): completionist_role = guild.get_role(Roles.aoc_completionist) if completionist_role is None: log.warning("Could not find the AoC completionist role; cancelling completionist task.") - self.completer_task.cancel() + self.completionist_task.cancel() return aoc_name_to_member_id = { @@ -97,13 +97,20 @@ class AdventOfCode(commands.Cog): member_id = aoc_name_to_member_id.get(member_aoc_info["name"], None) if not member_id: + log.debug(f"Could not find member_id for {member_aoc_info['name']}, not giving role.") continue member = await members.get_or_fetch_member(guild, member_id) - if member is None or completionist_role in member.roles: + if member is None: + log.debug(f"Could not find {member_id}, not giving role.") + continue + + if completionist_role in member.roles: + log.debug(f"{member.name} ({member.mention}) already has the completionist role.") continue if not await self.completionist_block_list.contains(member_id): + log.debug(f"Giving completionist role to {member.name} ({member.mention}).") await members.handle_role_change(member, member.add_roles, completionist_role) @commands.group(name="adventofcode", aliases=("aoc",)) diff --git a/bot/utils/members.py b/bot/utils/members.py index 9c8c8dd8..de5850ca 100644 --- a/bot/utils/members.py +++ b/bot/utils/members.py @@ -39,7 +39,7 @@ async def handle_role_change( except discord.NotFound: log.debug(f"Failed to change role for {member} ({member.id}): member not found") except discord.Forbidden: - log.debug( + log.error( f"Forbidden to change role for {member} ({member.id}); " f"possibly due to role hierarchy" ) |