Fix Linting Errors

Signed-off-by: Hassan Abouelela <[email protected]>

3 files changed, 7 insertions, 7 deletions

diff --git a/backend/models/discord_role.py b/backend/models/discord_role.py
index 9f0b7dd..c05c9de 100644
--- a/backend/models/discord_role.py
+++ b/backend/models/discord_role.py
@@ -10,7 +10,7 @@ class RoleTags(BaseModel):
     integration_id: typing.Optional[str]
     premium_subscriber: bool
 
-    def __init__(self, **data: typing.Any):
+    def __init__(self, **data: typing.Any) -> None:
         """
         Handle the terrible discord API.
 
diff --git a/backend/models/form.py b/backend/models/form.py
index 4ee2804..f888d6e 100644
--- a/backend/models/form.py
+++ b/backend/models/form.py
@@ -70,7 +70,7 @@ class Form(BaseModel):
         return value
 
     @validator("response_readers", "editors")
-    def validate_role_scoping(cls, value: t.Optional[list[str]]):
+    def validate_role_scoping(cls, value: t.Optional[list[str]]) -> t.Optional[list[str]]:
         """Ensure special role based permissions aren't granted to the @everyone role."""
         if value and str(DISCORD_GUILD) in value:
             raise ValueError("You can not add the everyone role as an access scope.")
diff --git a/backend/routes/discord.py b/backend/routes/discord.py
index a980d94..bca1edb 100644
--- a/backend/routes/discord.py
+++ b/backend/routes/discord.py
@@ -7,7 +7,7 @@ from starlette.responses import JSONResponse
 from starlette.routing import Request
 
 from backend import discord, models, route
-from backend.validation import ErrorMessage, OkayResponse, api
+from backend.validation import ErrorMessage, api
 
 NOT_FOUND_EXCEPTION = JSONResponse(
     {"error": "Could not find the requested resource in the guild or cache."}, status_code=404
@@ -27,7 +27,7 @@ class RolesRoute(route.Route):
 
     @requires(["authenticated", "admin"])
     @api.validate(
-        resp=Response(HTTP_200=OkayResponse),
+        resp=Response(HTTP_200=RolesResponse),
         tags=["roles"]
     )
     async def patch(self, request: Request) -> JSONResponse:
@@ -35,7 +35,7 @@ class RolesRoute(route.Route):
         roles = await discord.get_roles(request.state.db, force_refresh=True)
 
         return JSONResponse(
-            {"status": "ok"},
+            {"roles": [role.dict() for role in roles]},
         )
 
 
@@ -56,7 +56,7 @@ class MemberRoute(route.Route):
         json=MemberRequest,
         tags=["auth"]
     )
-    async def delete(self, request: Request):
+    async def delete(self, request: Request) -> JSONResponse:
         """Force a resync of the cache for the given user."""
         body = await request.json()
         member = await discord.get_member(request.state.db, body["user_id"], force_refresh=True)
@@ -72,7 +72,7 @@ class MemberRoute(route.Route):
         json=MemberRequest,
         tags=["auth"]
     )
-    async def get(self, request: Request):
+    async def get(self, request: Request) -> JSONResponse:
         """Get a user's roles on the configured server."""
         body = await request.json()
         member = await discord.get_member(request.state.db, body["user_id"])