diff options
author | 2021-02-28 14:34:12 +0300 | |
---|---|---|
committer | 2021-02-28 14:34:12 +0300 | |
commit | 637d61e1e9b4f1f4643c7f56ed7f7b0b6fedbac8 (patch) | |
tree | 6ceebd48bad1630799d4141510e599bbb412b567 /backend/routes/forms/submit.py | |
parent | Dynamically Selects OAuth Redirect URI (diff) | |
parent | Merge pull request #63 from python-discord/feat/9/unittest-validation (diff) |
Merge branch 'main' into token-expiry
# Conflicts:
# backend/routes/forms/form.py
# backend/routes/forms/submit.py
Diffstat (limited to 'backend/routes/forms/submit.py')
-rw-r--r-- | backend/routes/forms/submit.py | 23 |
1 files changed, 22 insertions, 1 deletions
diff --git a/backend/routes/forms/submit.py b/backend/routes/forms/submit.py index 8627a29..4224586 100644 --- a/backend/routes/forms/submit.py +++ b/backend/routes/forms/submit.py @@ -20,6 +20,7 @@ from backend import constants from backend.authentication.user import User from backend.models import Form, FormResponse from backend.route import Route +from backend.routes.forms.unittesting import execute_unittest from backend.validation import ErrorMessage, api HCAPTCHA_VERIFY_URL = "https://hcaptcha.com/siteverify" @@ -129,7 +130,10 @@ class SubmitForm(Route): response["user"] = request.user.payload response["user"]["admin"] = request.user.admin - if constants.FormFeatures.COLLECT_EMAIL.value in form.features and "email" not in response["user"]: # noqa + if ( + constants.FormFeatures.COLLECT_EMAIL.value in form.features + and "email" not in response["user"] + ): return JSONResponse({ "error": "email_required" }, status_code=400) @@ -157,6 +161,23 @@ class SubmitForm(Route): except ValidationError as e: return JSONResponse(e.errors(), status_code=422) + # Run unittests if needed + if any("unittests" in question.data for question in form.questions): + unittest_results = await execute_unittest(response_obj, form) + + if not all(test.passed for test in unittest_results): + # Return 500 if we encountered an internal error (code 99). + status_code = 500 if any( + test.return_code == 99 for test in unittest_results + ) else 403 + + return JSONResponse({ + "error": "failed_tests", + "test_results": [ + test._asdict() for test in unittest_results if not test.passed + ] + }, status_code=status_code) + await request.state.db.responses.insert_one( response_obj.dict(by_alias=True) ) |