1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
|
import asyncio
import datetime
from unittest.mock import MagicMock, patch
import pytest
from dateutil.relativedelta import relativedelta
from discord.ext.commands import BadArgument
from bot.converters import (
Duration,
ISODateTime,
TagContentConverter,
TagNameConverter,
ValidPythonIdentifier,
)
@pytest.mark.parametrize(
('value', 'expected'),
(
('hello', 'hello'),
(' h ello ', 'h ello')
)
)
def test_tag_content_converter_for_valid(value: str, expected: str):
assert asyncio.run(TagContentConverter.convert(None, value)) == expected
@pytest.mark.parametrize(
('value', 'expected'),
(
('', "Tag contents should not be empty, or filled with whitespace."),
(' ', "Tag contents should not be empty, or filled with whitespace.")
)
)
def test_tag_content_converter_for_invalid(value: str, expected: str):
context = MagicMock()
context.author = 'bob'
with pytest.raises(BadArgument, match=expected):
asyncio.run(TagContentConverter.convert(context, value))
@pytest.mark.parametrize(
('value', 'expected'),
(
('tracebacks', 'tracebacks'),
('Tracebacks', 'tracebacks'),
(' Tracebacks ', 'tracebacks'),
)
)
def test_tag_name_converter_for_valid(value: str, expected: str):
assert asyncio.run(TagNameConverter.convert(None, value)) == expected
@pytest.mark.parametrize(
('value', 'expected'),
(
('👋', "Don't be ridiculous, you can't use that character!"),
('', "Tag names should not be empty, or filled with whitespace."),
(' ', "Tag names should not be empty, or filled with whitespace."),
('42', "Tag names can't be numbers."),
# Escape question mark as this is evaluated as regular expression.
('x' * 128, r"Are you insane\? That's way too long!"),
)
)
def test_tag_name_converter_for_invalid(value: str, expected: str):
context = MagicMock()
context.author = 'bob'
with pytest.raises(BadArgument, match=expected):
asyncio.run(TagNameConverter.convert(context, value))
@pytest.mark.parametrize('value', ('foo', 'lemon'))
def test_valid_python_identifier_for_valid(value: str):
assert asyncio.run(ValidPythonIdentifier.convert(None, value)) == value
@pytest.mark.parametrize('value', ('nested.stuff', '#####'))
def test_valid_python_identifier_for_invalid(value: str):
with pytest.raises(BadArgument, match=f'`{value}` is not a valid Python identifier'):
asyncio.run(ValidPythonIdentifier.convert(None, value))
FIXED_UTC_NOW = datetime.datetime.fromisoformat('2019-01-01T00:00:00')
@pytest.fixture(
params=(
# Simple duration strings
('1Y', {"years": 1}),
('1y', {"years": 1}),
('1year', {"years": 1}),
('1years', {"years": 1}),
('1m', {"months": 1}),
('1month', {"months": 1}),
('1months', {"months": 1}),
('1w', {"weeks": 1}),
('1W', {"weeks": 1}),
('1week', {"weeks": 1}),
('1weeks', {"weeks": 1}),
('1d', {"days": 1}),
('1D', {"days": 1}),
('1day', {"days": 1}),
('1days', {"days": 1}),
('1h', {"hours": 1}),
('1H', {"hours": 1}),
('1hour', {"hours": 1}),
('1hours', {"hours": 1}),
('1M', {"minutes": 1}),
('1minute', {"minutes": 1}),
('1minutes', {"minutes": 1}),
('1s', {"seconds": 1}),
('1S', {"seconds": 1}),
('1second', {"seconds": 1}),
('1seconds', {"seconds": 1}),
# Complex duration strings
(
'1y1m1w1d1H1M1S',
{
"years": 1,
"months": 1,
"weeks": 1,
"days": 1,
"hours": 1,
"minutes": 1,
"seconds": 1
}
),
('5y100S', {"years": 5, "seconds": 100}),
('2w28H', {"weeks": 2, "hours": 28}),
# Duration strings with spaces
('1 year 2 months', {"years": 1, "months": 2}),
('1d 2H', {"days": 1, "hours": 2}),
('1 week2 days', {"weeks": 1, "days": 2}),
)
)
def create_future_datetime(request):
"""Yields duration string and target datetime.datetime object."""
duration, duration_dict = request.param
future_datetime = FIXED_UTC_NOW + relativedelta(**duration_dict)
yield duration, future_datetime
def test_duration_converter_for_valid(create_future_datetime: tuple):
converter = Duration()
duration, expected = create_future_datetime
with patch('bot.converters.datetime') as mock_datetime:
mock_datetime.utcnow.return_value = FIXED_UTC_NOW
assert asyncio.run(converter.convert(None, duration)) == expected
@pytest.mark.parametrize(
('duration'),
(
# Units in wrong order
('1d1w'),
('1s1y'),
# Duplicated units
('1 year 2 years'),
('1 M 10 minutes'),
# Unknown substrings
('1MVes'),
('1y3breads'),
# Missing amount
('ym'),
# Incorrect whitespace
(" 1y"),
("1S "),
("1y 1m"),
# Garbage
('Guido van Rossum'),
('lemon lemon lemon lemon lemon lemon lemon'),
)
)
def test_duration_converter_for_invalid(duration: str):
converter = Duration()
with pytest.raises(BadArgument, match=f'`{duration}` is not a valid duration string.'):
asyncio.run(converter.convert(None, duration))
@pytest.mark.parametrize(
("datetime_string", "expected_dt"),
(
# `YYYY-mm-ddTHH:MM:SSZ` | `YYYY-mm-dd HH:MM:SSZ`
('2019-09-02T02:03:05Z', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02 02:03:05Z', datetime.datetime(2019, 9, 2, 2, 3, 5)),
# `YYYY-mm-ddTHH:MM:SS±HH:MM` | `YYYY-mm-dd HH:MM:SS±HH:MM`
('2019-09-02T03:18:05+01:15', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02 03:18:05+01:15', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02T00:48:05-01:15', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02 00:48:05-01:15', datetime.datetime(2019, 9, 2, 2, 3, 5)),
# `YYYY-mm-ddTHH:MM:SS±HHMM` | `YYYY-mm-dd HH:MM:SS±HHMM`
('2019-09-02T03:18:05+0115', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02 03:18:05+0115', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02T00:48:05-0115', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02 00:48:05-0115', datetime.datetime(2019, 9, 2, 2, 3, 5)),
# `YYYY-mm-ddTHH:MM:SS±HH` | `YYYY-mm-dd HH:MM:SS±HH`
('2019-09-02 03:03:05+01', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02T01:03:05-01', datetime.datetime(2019, 9, 2, 2, 3, 5)),
# `YYYY-mm-ddTHH:MM:SS` | `YYYY-mm-dd HH:MM:SS`
('2019-09-02T02:03:05', datetime.datetime(2019, 9, 2, 2, 3, 5)),
('2019-09-02 02:03:05', datetime.datetime(2019, 9, 2, 2, 3, 5)),
# `YYYY-mm-ddTHH:MM` | `YYYY-mm-dd HH:MM`
('2019-11-12T09:15', datetime.datetime(2019, 11, 12, 9, 15)),
('2019-11-12 09:15', datetime.datetime(2019, 11, 12, 9, 15)),
# `YYYY-mm-dd`
('2019-04-01', datetime.datetime(2019, 4, 1)),
# `YYYY-mm`
('2019-02-01', datetime.datetime(2019, 2, 1)),
# `YYYY`
('2025', datetime.datetime(2025, 1, 1)),
),
)
def test_isodatetime_converter_for_valid(datetime_string: str, expected_dt: datetime.datetime):
converter = ISODateTime()
converted_dt = asyncio.run(converter.convert(None, datetime_string))
assert converted_dt.tzinfo is None
assert converted_dt == expected_dt
@pytest.mark.parametrize(
("datetime_string"),
(
# Make sure it doesn't interfere with the Duration converter
('1Y'),
('1d'),
('1H'),
# Check if it fails when only providing the optional time part
('10:10:10'),
('10:00'),
# Invalid date format
('19-01-01'),
# Other non-valid strings
('fisk the tag master'),
),
)
def test_isodatetime_converter_for_invalid(datetime_string: str):
converter = ISODateTime()
with pytest.raises(
BadArgument,
match=f"`{datetime_string}` is not a valid ISO-8601 datetime string",
):
asyncio.run(converter.convert(None, datetime_string))
|
