aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Merge branch 'master' into channel_constants_checkGravatar Mark2020-02-27-9/+20
|\
| * Merge pull request #790 from ks129/masterGravatar S. Co12020-02-26-2/+8
| |\ | | | | | | Added ignoring staff to Antimalware check.
| | * Add clarifying comment to role checking logic implementationGravatar S. Co12020-02-26-0/+1
| | |
| | * Merge branch 'master' into masterGravatar S. Co12020-02-26-7/+12
| | |\ | | |/ | |/|
| * | Disable TRACE logging for Sentry breadcrumbs.Gravatar Joseph2020-02-26-1/+1
| | |
| * | Merge pull request #781 from ↵Gravatar S. Co12020-02-25-6/+11
| |\ \ | | | | | | | | | | | | | | | | python-discord/bug/utils/bot-1c/reminder-unschedule-failure Reminders: don't cancel task if reminder is invalid when rescheduling
| | * \ Merge branch 'master' into bug/utils/bot-1c/reminder-unschedule-failureGravatar Joseph2020-02-25-551/+1704
| | |\ \ | | |/ / | |/| |
| | * | Reminders: don't cancel task if reminder is invalid when reschedulingGravatar MarkKoz2020-02-23-6/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a reminder is invalid, it won't get rescheduled. Therefore, there wouldn't exist a task to cancel and it'd raise a warning. Fixes BOT-1C
| | | * Added DMs ignoring to antimalware checkGravatar ks1232020-02-26-1/+2
| | | |
| | | * Added to AntiMalware staff ignore check.Gravatar Karlis. S2020-02-26-1/+5
| | |/ | |/|
* | | Fix comparison operator when checking token expiration.Gravatar Numerlor2020-02-26-1/+1
| | | | | | | | | | | | With `<` the check only went through when the token was already expired, making revoking redundant; and didn't go through when the token still had some time before expiration.
* | | Check for falsy values instead of ``""` and `None` explicitly.Gravatar Numerlor2020-02-26-2/+1
| | | | | | | | | | | | | | | | | | After the change to also check empty strings to avoid unucessary requests, it is no longer necessary to do an explicit value check, as the only values that can come from the .env file are `None` and strings Co-authored-by: Karlis S <[email protected]>
* | | Specify the logged time is in UTC.Gravatar Numerlor2020-02-26-1/+1
| | |
* | | Create task for `revoke_access_token` when unloading cog to ensure it's ↵Gravatar Numerlor2020-02-26-1/+1
| | | | | | | | | | | | executed.
* | | Make sure token exists before checking its expiration.Gravatar Numerlor2020-02-26-1/+1
| | | | | | | | | | | | Without the check and an invalid token, an AttributeError is raised; blocking the relevant ClientError from being raised in `get_access_token`.
* | | Check for empty strings alongside None before loading cog.Gravatar Numerlor2020-02-26-1/+2
| | | | | | | | | | | | Docker fetches values from the .env itself and defaults to "" instead of None, needing to do invalid access token requests before unloading itself.
* | | Restyle if body to include the error instead of adding the cog.Gravatar Numerlor2020-02-25-3/+3
| | |
* | | Fix `__iter__` for classes without subsections.Gravatar Numerlor2020-02-25-2/+3
| | | | | | | | | | | | | | | | | | The previous implementation assumed the config class was a subsection, failing with a KeyError if it wasn't one. Co-authored-by: kwzrd <[email protected]>
* | | Assign created task to a variable.Gravatar Numerlor2020-02-25-1/+1
| | | | | | | | | | | | Co-authored-by: SebastiaanZ <[email protected]>
* | | Wait for available guild instead of bot startup.Gravatar Numerlor2020-02-25-1/+1
| | | | | | | | | | | | Co-authored-by: SebastiaanZ <[email protected]>
* | | Merge branch 'master' into channel_constants_checkGravatar Numerlor2020-02-25-551/+1704
|\| |
| * | Merge pull request #711 from python-discord/bug/backend/b704/ready-missing-cacheGravatar Mark2020-02-23-536/+1657
| |\ \ | | | | | | | | Prevent the role syncer from wiping the database table during API latency
| | * \ Merge remote-tracking branch 'origin/master' into ↵Gravatar MarkKoz2020-02-23-621/+997
| | |\ \ | | |/ / | |/| | | | | | bug/backend/b704/ready-missing-cache
| * | | Merge pull request #749 from python-discord/reminder-enhancementsGravatar Leon Sandøy2020-02-23-15/+47
| |\ \ \ | | |_|/ | |/| | Reminder Embed Enhancements & Whitelist Expansion
| | * | Merge branch 'master' into reminder-enhancementsGravatar S. Co12020-02-23-607/+951
| | |\ \ | | |/ / | |/| |
| | * | Add missed signature reformat from reviewGravatar S. Co12020-02-15-1/+4
| | | | | | | | | | | | Co-Authored-By: Mark <[email protected]>
| | * | Add "cancel" as a reminder delete aliasGravatar S. Co12020-02-15-1/+1
| | | |
| | * | Add full capture of reason string to superstarify invocationGravatar S. Co12020-02-15-1/+2
| | | |
| | * | Styling & refactors from reviewGravatar S. Co12020-02-15-17/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Refactor confirmation embed footer string generation to be more concise * Multiline long method calls * Refactor humanized delta f string generation for readability * Switch from `datetime.isoformat` to `dateutils.parser.isoparse` to align with changes elsewhere in the codebase (should be more robust) * Shift reminder channel whitelist to constants Co-Authored-By: Mark <[email protected]>
| | * | Expand reminder channel whitelist to dev-contrib for non-staffGravatar S. Co12020-02-12-1/+3
| | | | | | | | | | | | Add channel ID to config files
| | * | Add reminder target datetime to footer of confirmation messageGravatar S. Co12020-02-12-5/+16
| | | |
| | * | Add reminder ID to footer of confirmation messageGravatar S. Co12020-02-12-5/+8
| | | |
| | | * Sync: code style refactoringGravatar MarkKoz2020-02-23-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | * Convert diff namedtuple to dict outside the dict comprehension * Define long condition as a boolean instead of in the if statement * Pass role and user dicts to aiohttp normally instead of unpacking
| | | * Bot: send empty cache warning to a webhookGravatar MarkKoz2020-02-21-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | This is more visible than it would be if it was only logged. * Add a webhook for the dev-log channel to constants
| | | * API: add comment explaining class attributesGravatar MarkKoz2020-02-19-0/+2
| | | | | | | | | | | | | | | | Explain changes caused by 22a55534ef13990815a6f69d361e2a12693075d5.
| | | * Sync: add confirmation timeout and max diff to configGravatar MarkKoz2020-02-19-16/+24
| | | |
| | | * Tests: fix unawaited error for MockAPIClientGravatar MarkKoz2020-02-12-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This error is due to the use of an actual instance of APIClient as the spec for the mock. recreate() is called in __init__ which in turn creates a task for the _create_session coroutine. The approach to the solution is to use the type for the spec rather than and instance, thus avoiding any call of __init__. However, without an instance, instance attributes will not be included in the spec. Therefore, they are defined as class attributes on the actual APIClient class definition and given default values. Alternatively, a subclass of APIClient could have been made in the tests.helpers module to define those class attributes. However, it seems easier to maintain if the attributes are in the original class definition.
| | | * Sync tests: use async_test decoratorGravatar MarkKoz2020-02-12-94/+135
| | | |
| | | * Sync tests: test on_member_joinGravatar MarkKoz2020-02-12-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | Should PUT user's data or POST it if the user doesn't exist. ResponseCodeError should be re-raised if status code isn't a 404. A helper method was added to reduce code redundancy between the 2 tests.
| | | * Sync tests: add a third role with a lower ID to on_member_update testGravatar MarkKoz2020-02-12-1/+2
| | | | | | | | | | | | | | | | This better ensures that roles are being sorted when patching.
| | | * Sync tests: fix on_member_remove listener testGravatar MarkKoz2020-02-12-13/+6
| | | | | | | | | | | | | | | | | | | | The listener was changed earlier to simply set in_guild to False. This commit accounts for that in the test.
| | | * Sync tests: assert that listeners are actually added as listenersGravatar MarkKoz2020-02-12-0/+14
| | | |
| | | * Sync tests: test sync commands require the admin permissionGravatar MarkKoz2020-02-12-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sync commands should only run if the author has the administrator permission. * Add missing spaces after class docstrings * Add missing docstring to SyncCogCommandTests
| | | * Tests: create TestCase subclass with a permissions check assertionGravatar MarkKoz2020-02-12-0/+34
| | | | | | | | | | | | | | | | | | | | | | | | The subclass will contain assertions that are useful for testing Discord commands. The currently included assertion tests that a command will raise a MissingPermissions exception if the author lacks permissions.
| | | * Sync: only update in_guild field when a member leavesGravatar MarkKoz2020-02-12-16/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The member and user update listeners should already be detecting and updating other fields so by the time a user leaves, the rest of the fields should be up-to-date. * Dedent condition which was indented too far
| | | * Sync tests: test sync users commandGravatar MarkKoz2020-02-12-0/+7
| | | | | | | | | | | | | | | | sync() should be called on the UserSyncer.
| | | * Sync tests: test sync roles commandGravatar MarkKoz2020-02-12-0/+9
| | | | | | | | | | | | | | | | sync() should be called on the RoleSyncer.
| | | * Sync tests: test Sync cog's on_user_updateGravatar MarkKoz2020-02-12-1/+42
| | | | | | | | | | | | | | | | | | | | A user should be patched only if the name, discriminator, or avatar changes.
| | | * Sync tests: fix ID in endpoint for test_sync_cog_on_member_removeGravatar MarkKoz2020-02-12-1/+1
| | | |
| | | * Sync tests: test Sync cog's on_member_update for other attributesGravatar MarkKoz2020-02-12-0/+21
| | | | | | | | | | | | | | | | Members should not be patched if other attributes have changed.