aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar S. Co1 <[email protected]>2020-02-26 16:00:31 -0500
committerGravatar GitHub <[email protected]>2020-02-26 16:00:31 -0500
commit2c8ac3d008e61c928ad1d478d1a9f8f3008b2853 (patch)
tree859b779d6300ba8f246dee54ca0348112d90df93
parentAdded DMs ignoring to antimalware check (diff)
parentDisable TRACE logging for Sentry breadcrumbs. (diff)
Merge branch 'master' into master
-rw-r--r--bot/__main__.py2
-rw-r--r--bot/cogs/reminders.py17
2 files changed, 12 insertions, 7 deletions
diff --git a/bot/__main__.py b/bot/__main__.py
index 490163739..a3f1855b5 100644
--- a/bot/__main__.py
+++ b/bot/__main__.py
@@ -10,7 +10,7 @@ from bot.bot import Bot
from bot.constants import Bot as BotConfig, DEBUG_MODE
sentry_logging = LoggingIntegration(
- level=logging.TRACE,
+ level=logging.DEBUG,
event_level=logging.WARNING
)
diff --git a/bot/cogs/reminders.py b/bot/cogs/reminders.py
index a642cbfdb..041791056 100644
--- a/bot/cogs/reminders.py
+++ b/bot/cogs/reminders.py
@@ -46,7 +46,7 @@ class Reminders(Scheduler, Cog):
loop = asyncio.get_event_loop()
for reminder in response:
- is_valid, *_ = self.ensure_valid_reminder(reminder)
+ is_valid, *_ = self.ensure_valid_reminder(reminder, cancel_task=False)
if not is_valid:
continue
@@ -59,7 +59,11 @@ class Reminders(Scheduler, Cog):
else:
self.schedule_task(loop, reminder["id"], reminder)
- def ensure_valid_reminder(self, reminder: dict) -> t.Tuple[bool, discord.User, discord.TextChannel]:
+ def ensure_valid_reminder(
+ self,
+ reminder: dict,
+ cancel_task: bool = True
+ ) -> t.Tuple[bool, discord.User, discord.TextChannel]:
"""Ensure reminder author and channel can be fetched otherwise delete the reminder."""
user = self.bot.get_user(reminder['author'])
channel = self.bot.get_channel(reminder['channel_id'])
@@ -70,7 +74,7 @@ class Reminders(Scheduler, Cog):
f"Reminder {reminder['id']} invalid: "
f"User {reminder['author']}={user}, Channel {reminder['channel_id']}={channel}."
)
- asyncio.create_task(self._delete_reminder(reminder['id']))
+ asyncio.create_task(self._delete_reminder(reminder['id'], cancel_task))
return is_valid, user, channel
@@ -111,12 +115,13 @@ class Reminders(Scheduler, Cog):
# Now we can begone with it from our schedule list.
self.cancel_task(reminder_id)
- async def _delete_reminder(self, reminder_id: str) -> None:
+ async def _delete_reminder(self, reminder_id: str, cancel_task: bool = True) -> None:
"""Delete a reminder from the database, given its ID, and cancel the running task."""
await self.bot.api_client.delete('bot/reminders/' + str(reminder_id))
- # Now we can remove it from the schedule list
- self.cancel_task(reminder_id)
+ if cancel_task:
+ # Now we can remove it from the schedule list
+ self.cancel_task(reminder_id)
async def _reschedule_reminder(self, reminder: dict) -> None:
"""Reschedule a reminder object."""