Merge pull request #422 from python-discord/bot-utils-checks-use-fixture

Use `@pytest.fixture` for creating contexts.

1 files changed, 15 insertions, 16 deletions

diff --git a/tests/utils/test_checks.py b/tests/utils/test_checks.py
index 915d074b3..7121acebd 100644
--- a/tests/utils/test_checks.py
+++ b/tests/utils/test_checks.py
@@ -1,25 +1,29 @@
 from unittest.mock import MagicMock
 
+import pytest
+
 from bot.utils import checks
 
 
-def test_with_role_check_without_guild():
-    context = MagicMock()
[email protected]()
+def context():
+    return MagicMock()
+
+
+def test_with_role_check_without_guild(context):
     context.guild = None
 
     assert not checks.with_role_check(context)
 
 
-def test_with_role_check_with_guild_without_required_role():
-    context = MagicMock()
+def test_with_role_check_with_guild_without_required_role(context):
     context.guild = True
     context.author.roles = []
 
     assert not checks.with_role_check(context)
 
 
-def test_with_role_check_with_guild_with_required_role():
-    context = MagicMock()
+def test_with_role_check_with_guild_with_required_role(context):
     context.guild = True
     role = MagicMock()
     role.id = 42
@@ -28,15 +32,13 @@ def test_with_role_check_with_guild_with_required_role():
     assert checks.with_role_check(context, role.id)
 
 
-def test_without_role_check_without_guild():
-    context = MagicMock()
+def test_without_role_check_without_guild(context):
     context.guild = None
 
     assert not checks.without_role_check(context)
 
 
-def test_without_role_check_with_unwanted_role():
-    context = MagicMock()
+def test_without_role_check_with_unwanted_role(context):
     context.guild = True
     role = MagicMock()
     role.id = 42
@@ -45,8 +47,7 @@ def test_without_role_check_with_unwanted_role():
     assert not checks.without_role_check(context, role.id)
 
 
-def test_without_role_check_without_unwanted_role():
-    context = MagicMock()
+def test_without_role_check_without_unwanted_role(context):
     context.guild = True
     role = MagicMock()
     role.id = 42
@@ -55,13 +56,11 @@ def test_without_role_check_without_unwanted_role():
     assert checks.without_role_check(context, role.id + 10)
 
 
-def test_in_channel_check_for_correct_channel():
-    context = MagicMock()
+def test_in_channel_check_for_correct_channel(context):
     context.channel.id = 42
     assert checks.in_channel_check(context, context.channel.id)
 
 
-def test_in_channel_check_for_incorrect_channel():
-    context = MagicMock()
+def test_in_channel_check_for_incorrect_channel(context):
     context.channel.id = 42
     assert not checks.in_channel_check(context, context.channel.id + 10)