aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar MarkKoz <[email protected]>2020-03-18 18:58:56 -0700
committerGravatar MarkKoz <[email protected]>2020-07-31 22:48:12 -0700
commitef24f6dcce1ed527f8561c4bfa41f390bde692bc (patch)
tree2c3b0f6089e1210243006d370d3dcd8544147c7c
parentRemove superfluous Available help channels. (diff)
Reminders: remove duplicate deletion in scheduled task
`send_reminder` already deletes the reminder so it's redundant to delete it in the scheduled task too.
-rw-r--r--bot/cogs/reminders.py10
1 files changed, 1 insertions, 9 deletions
diff --git a/bot/cogs/reminders.py b/bot/cogs/reminders.py
index b5998cc0e..cbc7d6920 100644
--- a/bot/cogs/reminders.py
+++ b/bot/cogs/reminders.py
@@ -144,16 +144,8 @@ class Reminders(Cog):
def schedule_reminder(self, reminder: dict) -> None:
"""A coroutine which sends the reminder once the time is reached, and cancels the running task."""
- reminder_id = reminder["id"]
reminder_datetime = isoparse(reminder['expiration']).replace(tzinfo=None)
-
- async def _remind() -> None:
- await self.send_reminder(reminder)
-
- log.debug(f"Deleting reminder {reminder_id} (the user has been reminded).")
- await self._delete_reminder(reminder_id)
-
- self.scheduler.schedule_at(reminder_datetime, reminder_id, _remind())
+ self.scheduler.schedule_at(reminder_datetime, reminder["id"], self.send_reminder(reminder))
async def _delete_reminder(self, reminder_id: str, cancel_task: bool = True) -> None:
"""Delete a reminder from the database, given its ID, and cancel the running task."""