Improve cache iteration speed

getitem based iteration included operations that aren't necessary when iterating over the cache continuously. Adding an iter method to the class seems to have improved iteration speed by several orders of magnitude.

1 files changed, 10 insertions, 0 deletions

diff --git a/bot/utils/message_cache.py b/bot/utils/message_cache.py
index f5656cdeb..f68d280c9 100644
--- a/bot/utils/message_cache.py
+++ b/bot/utils/message_cache.py
@@ -170,6 +170,16 @@ class MessageCache:
         else:
             raise TypeError(f"cache indices must be integers or slices, not {type(item)}")
 
+    def __iter__(self) -> t.Iterator[Message]:
+        if self._is_empty():
+            return
+
+        if self._start < self._end:
+            yield from self._messages[self._start:self._end]
+        else:
+            yield from self._messages[self._start:]
+            yield from self._messages[:self._end]
+
     def __len__(self):
         """Get the number of non-empty cells in the cache."""
         if self._is_empty():