diff options
| author | 2020-07-16 11:45:15 +0800 | |
|---|---|---|
| committer | 2020-07-16 11:45:15 +0800 | |
| commit | 776b4379c478284803a4a526b5f14fe63d8e7c01 (patch) | |
| tree | 2d4ae71d586e5fb75146cd18b46939028cdeeb78 | |
| parent | Merge pull request #1041 from python-discord/dm_relay (diff) | |
Remove duplicate reminder deletion.
The function `_delete_reminder` was called twice, once in
`schedule_reminder`, which calls `send_reminder`, then another in
`send_reminder` itself. This led to a 404 response from the site api, as
the reminder was already deleted the first time.
Fixes BOT-6W
| -rw-r--r-- | bot/cogs/reminders.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bot/cogs/reminders.py b/bot/cogs/reminders.py index 0d20bdb2b..4f2ab1781 100644 --- a/bot/cogs/reminders.py +++ b/bot/cogs/reminders.py @@ -55,6 +55,7 @@ class Reminders(Cog): if remind_at < now: late = relativedelta(now, remind_at) await self.send_reminder(reminder, late) + await self._delete_reminder(reminder["id"]) else: self.schedule_reminder(reminder) @@ -157,7 +158,6 @@ class Reminders(Cog): content=user.mention, embed=embed ) - await self._delete_reminder(reminder["id"]) @group(name="remind", aliases=("reminder", "reminders", "remindme"), invoke_without_command=True) async def remind_group(self, ctx: Context, expiration: Duration, *, content: str) -> None: |