aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Boris Muratov <[email protected]>2021-03-19 20:50:57 +0200
committerGravatar Boris Muratov <[email protected]>2021-03-19 20:50:57 +0200
commit3bf532b4ba499fc276c94f1cd6d3d859afbb925e (patch)
treef6ed37183dcfdfce1f8c31d1a504a6274d741720
parentMark as reviewed when nominee is off server (diff)
Don't reschedule reviews that are long overdue
If it's been over a day overdue for a review, don't reschedule it. This is done in order to not fire reviews for all nominations which are over 30 days old when the auto-reviewing feature is merged.
-rw-r--r--bot/exts/recruitment/talentpool/_review.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/bot/exts/recruitment/talentpool/_review.py b/bot/exts/recruitment/talentpool/_review.py
index 49aee8970..ba1564602 100644
--- a/bot/exts/recruitment/talentpool/_review.py
+++ b/bot/exts/recruitment/talentpool/_review.py
@@ -61,7 +61,9 @@ class Reviewer:
inserted_at = isoparse(user_data['inserted_at']).replace(tzinfo=None)
review_at = inserted_at + timedelta(days=MAX_DAYS_IN_POOL)
- self._review_scheduler.schedule_at(review_at, user_id, self.post_review(user_id, update_database=True))
+ # If it's over a day overdue, it's probably an old nomination and shouldn't be automatically reviewed.
+ if datetime.utcnow() - review_at < timedelta(days=1):
+ self._review_scheduler.schedule_at(review_at, user_id, self.post_review(user_id, update_database=True))
async def post_review(self, user_id: int, update_database: bool) -> None:
"""Format a generic review of a user and post it to the mod announcements channel."""