diff options
| author |  Sebastiaan Zeeff <[email protected]> | 2020-12-11 06:45:21 +0100 |
|---|---|---|
| committer |  GitHub <[email protected]> | 2020-12-11 06:45:21 +0100 |
| commit | 35f7ecda15e017afd184a94404d21c3f97cd0583 (patch) | |
| tree | 1c1f0d7d5c2ed66c709fe90fc78127b93f40d888 | |
| parent | Send a custom workflow status embed to Discord (diff) | |
Make sure PR build artifact is always uploaded
GitHub Actions has an implicit status condition, `success()`, that
is added whenever an `if` condition lacks a status function check
of its own. In this case, while the upload step did check for the
outcome of the previous "always" step, it did not have an actual
status check and, thus, only ran on success.
Since we always want to upload the artifact, even if other steps
failed, I've added the "always" status function now.
| -rw-r--r-- | .github/workflows/lint-test.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/workflows/lint-test.yml b/.github/workflows/lint-test.yml index a38f031fa..6fa8e8333 100644 --- a/.github/workflows/lint-test.yml +++ b/.github/workflows/lint-test.yml @@ -129,7 +129,7 @@ jobs: # `continue-on-error` conclusion is applied, we use the # `.outcome` value. This step also fails silently. - name: Upload a Build Artifact - if: steps.prepare-artifact.outcome == 'success' + if: always() && steps.prepare-artifact.outcome == 'success' continue-on-error: true uses: actions/upload-artifact@v2 with: |