From 115a181cd51f14cd9cf74168fdf5914cbcec51bc Mon Sep 17 00:00:00 2001 From: SebastiaanZ <33516116+SebastiaanZ@users.noreply.github.com> Date: Fri, 12 Jul 2019 10:18:55 +0200 Subject: Changing logic so an end_reason can never be specified when updating an active nomination --- pydis_site/apps/api/viewsets/bot/nomination.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pydis_site') diff --git a/pydis_site/apps/api/viewsets/bot/nomination.py b/pydis_site/apps/api/viewsets/bot/nomination.py index 3595bec3..a9dacd68 100644 --- a/pydis_site/apps/api/viewsets/bot/nomination.py +++ b/pydis_site/apps/api/viewsets/bot/nomination.py @@ -194,7 +194,7 @@ class NominationViewSet(CreateModelMixin, RetrieveModelMixin, ListModelMixin, Ge # There are three distinct PATCH scenarios we need to validate. if instance.active and 'active' not in data: # 1. We're updating an active nomination without ending it. - if request.data.get('end_reason'): + if 'end_reason' in data: raise ValidationError( {'end_reason': ["An active nomination can't have an end reason."]} ) -- cgit v1.2.3