From 873eaadbe0376a792293df65bbc754b0f9e33673 Mon Sep 17 00:00:00 2001 From: ks129 <45097959+ks129@users.noreply.github.com> Date: Tue, 6 Oct 2020 17:27:05 +0300 Subject: Simplify relevant links generator empty values filtering --- pydis_site/apps/content/views/article.py | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) (limited to 'pydis_site/apps/content/views') diff --git a/pydis_site/apps/content/views/article.py b/pydis_site/apps/content/views/article.py index f4c834db..02e8103f 100644 --- a/pydis_site/apps/content/views/article.py +++ b/pydis_site/apps/content/views/article.py @@ -26,22 +26,17 @@ class ArticleView(View): else: category_data = {"name": None, "raw_name": None} - relevant_links = { - link: value for link, value in zip( - article_result["metadata"].get("relevant_links", "").split(","), - article_result["metadata"].get("relevant_link_values", "").split(",") - ) - } - - if relevant_links == {"": ""}: - relevant_links = {} - return render( request, "content/article.html", { "article": article_result, "category_data": category_data, - "relevant_links": relevant_links + "relevant_links": { + link: value for link, value in zip( + article_result["metadata"].get("relevant_links", "").split(","), + article_result["metadata"].get("relevant_link_values", "").split(",") + ) if link != "" and value != "" + }, } ) -- cgit v1.2.3