From ab17a7a80e6f90a4dddb04325c29deb8065f1499 Mon Sep 17 00:00:00 2001 From: Chris Lovering Date: Tue, 12 Dec 2023 15:58:24 +0000 Subject: Simplify is_bot_pr_approval logic --- pydis_site/apps/api/views.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'pydis_site/apps/api') diff --git a/pydis_site/apps/api/views.py b/pydis_site/apps/api/views.py index 20c7536c..1fa3efc2 100644 --- a/pydis_site/apps/api/views.py +++ b/pydis_site/apps/api/views.py @@ -272,10 +272,7 @@ class GitHubWebhookFilterView(APIView): 'dependabot' in request.data.get('ref', '').lower() and event == 'delete' ) - is_bot_pr_approval = ( - '[bot]' in request.data.get('pull_request', {}).get('user', {}).get('login', '').lower() - and event == 'pull_request_review' - ) + is_bot_pr_approval = is_github_bot and event == 'pull_request_review' is_empty_review = ( request.data.get('review', {}).get('state', '').lower() == 'commented' and event == 'pull_request_review' -- cgit v1.2.3