From 8066a3360b23508d3fb2da3d37d2c63f2630faff Mon Sep 17 00:00:00 2001
From: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
Date: Thu, 22 Aug 2019 20:38:51 +0200
Subject: Adding required fields validator and tests to embed fields

---
 pydis_site/apps/api/tests/test_validators.py | 39 ++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

(limited to 'pydis_site/apps/api/tests')

diff --git a/pydis_site/apps/api/tests/test_validators.py b/pydis_site/apps/api/tests/test_validators.py
index ffa2f61e..4222f0c0 100644
--- a/pydis_site/apps/api/tests/test_validators.py
+++ b/pydis_site/apps/api/tests/test_validators.py
@@ -119,18 +119,53 @@ class TagEmbedValidatorTests(TestCase):
                         'value': "LOOK AT ME"
                     },
                     {
+                        'name': "Totally valid",
+                        'value': "LOOK AT ME",
                         'oh': "what is this key?"
                     }
                 ]
             })
 
+    def test_rejects_missing_required_field_field(self):
+        with self.assertRaises(ValidationError):
+            validate_tag_embed({
+                'fields': [
+                    {
+                        'name': "Totally valid",
+                        'inline': True,
+                    }
+                ]
+            })
+
+    def test_rejects_invalid_inline_field_field(self):
+        with self.assertRaises(ValidationError):
+            validate_tag_embed({
+                'fields': [
+                    {
+                        'name': "Totally valid",
+                        'value': "LOOK AT ME",
+                        'inline': "Totally not a boolean",
+                    }
+                ]
+            })
+
     def test_allows_valid_fields(self):
         validate_tag_embed({
             'fields': [
                 {
                     'name': "valid",
-                    'value': "field"
-                }
+                    'value': "field",
+                },
+                {
+                    'name': "valid",
+                    'value': "field",
+                    'inline': False,
+                },
+                {
+                    'name': "valid",
+                    'value': "field",
+                    'inline': True,
+                },
             ]
         })
 
-- 
cgit v1.2.3