From f1bdb525af330f28742638fdaa19cd8c76235906 Mon Sep 17 00:00:00 2001
From: ks129 <45097959+ks129@users.noreply.github.com>
Date: Sat, 10 Oct 2020 20:15:01 +0300
Subject: Cover metricity voice ban status with tests

---
 pydis_site/apps/api/tests/test_users.py | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

(limited to 'pydis_site/apps/api/tests')

diff --git a/pydis_site/apps/api/tests/test_users.py b/pydis_site/apps/api/tests/test_users.py
index d03785ae..01bf208b 100644
--- a/pydis_site/apps/api/tests/test_users.py
+++ b/pydis_site/apps/api/tests/test_users.py
@@ -1,5 +1,6 @@
 from unittest.mock import patch
 
+from django.core.exceptions import MultipleObjectsReturned, ObjectDoesNotExist
 from django_hosts.resolvers import reverse
 
 from .base import APISubdomainTestCase
@@ -419,6 +420,7 @@ class UserMetricityTests(APISubdomainTestCase):
         self.assertEqual(response.json(), {
             "verified_at": verified_at,
             "total_messages": total_messages,
+            "voice_banned": False,
         })
 
     def test_no_metricity_user(self):
@@ -432,6 +434,27 @@ class UserMetricityTests(APISubdomainTestCase):
         # Then
         self.assertEqual(response.status_code, 404)
 
+    def test_metricity_voice_banned(self):
+        cases = [
+            {'exception': None, 'voice_banned': True},
+            {'exception': ObjectDoesNotExist, 'voice_banned': False},
+            {'exception': MultipleObjectsReturned, 'voice_banned': True},
+        ]
+
+        self.mock_metricity_user("foo", 1)
+
+        for case in cases:
+            with self.subTest(exception=case['exception'], voice_banned=case['voice_banned']):
+                with patch("pydis_site.apps.api.viewsets.bot.user.Infraction.objects.get") as p:
+                    p.side_effect = case['exception']
+
+                    url = reverse('bot:user-metricity-data', args=[0], host='api')
+                    response = self.client.get(url)
+
+                    self.assertEqual(response.status_code, 200)
+                    self.assertEqual(response.json()["voice_banned"], case["voice_banned"])
+
+
     def mock_metricity_user(self, verified_at, total_messages):
         patcher = patch("pydis_site.apps.api.viewsets.bot.user.Metricity")
         self.metricity = patcher.start()
-- 
cgit v1.2.3


From 8cb18e635920d64734a66be77e849cae3441108b Mon Sep 17 00:00:00 2001
From: ks129 <45097959+ks129@users.noreply.github.com>
Date: Sat, 10 Oct 2020 20:21:42 +0300
Subject: Remove unnecessary newline from user tests

---
 pydis_site/apps/api/tests/test_users.py | 1 -
 1 file changed, 1 deletion(-)

(limited to 'pydis_site/apps/api/tests')

diff --git a/pydis_site/apps/api/tests/test_users.py b/pydis_site/apps/api/tests/test_users.py
index 01bf208b..e512f506 100644
--- a/pydis_site/apps/api/tests/test_users.py
+++ b/pydis_site/apps/api/tests/test_users.py
@@ -454,7 +454,6 @@ class UserMetricityTests(APISubdomainTestCase):
                     self.assertEqual(response.status_code, 200)
                     self.assertEqual(response.json()["voice_banned"], case["voice_banned"])
 
-
     def mock_metricity_user(self, verified_at, total_messages):
         patcher = patch("pydis_site.apps.api.viewsets.bot.user.Metricity")
         self.metricity = patcher.start()
-- 
cgit v1.2.3


From 42e34e955724eb47a505e24bcd03dc55c8e66419 Mon Sep 17 00:00:00 2001
From: ks129 <45097959+ks129@users.noreply.github.com>
Date: Sat, 10 Oct 2020 20:36:18 +0300
Subject: Remove multiple objects returning test case

---
 pydis_site/apps/api/tests/test_users.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'pydis_site/apps/api/tests')

diff --git a/pydis_site/apps/api/tests/test_users.py b/pydis_site/apps/api/tests/test_users.py
index e512f506..72ffcb3c 100644
--- a/pydis_site/apps/api/tests/test_users.py
+++ b/pydis_site/apps/api/tests/test_users.py
@@ -1,6 +1,6 @@
 from unittest.mock import patch
 
-from django.core.exceptions import MultipleObjectsReturned, ObjectDoesNotExist
+from django.core.exceptions import ObjectDoesNotExist
 from django_hosts.resolvers import reverse
 
 from .base import APISubdomainTestCase
@@ -438,7 +438,6 @@ class UserMetricityTests(APISubdomainTestCase):
         cases = [
             {'exception': None, 'voice_banned': True},
             {'exception': ObjectDoesNotExist, 'voice_banned': False},
-            {'exception': MultipleObjectsReturned, 'voice_banned': True},
         ]
 
         self.mock_metricity_user("foo", 1)
-- 
cgit v1.2.3