From 56697a64f752c2d4d0ca599aa445e0a05855972a Mon Sep 17 00:00:00 2001 From: jchristgit Date: Thu, 1 May 2025 20:38:56 +0200 Subject: Do not require "active" to be sent in PATCH infraction (#1518) Regression from the DRF update. --- pydis_site/apps/api/tests/test_infractions.py | 2 +- pydis_site/apps/api/viewsets/bot/infraction.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pydis_site/apps/api/tests/test_infractions.py b/pydis_site/apps/api/tests/test_infractions.py index 4830833c..af568ea1 100644 --- a/pydis_site/apps/api/tests/test_infractions.py +++ b/pydis_site/apps/api/tests/test_infractions.py @@ -329,7 +329,7 @@ class InfractionTests(AuthenticatedAPITestCase): def test_partial_update_returns_400_for_frozen_field(self): url = reverse('api:bot:infraction-detail', args=(self.ban_hidden.id,)) - data = {'user': 6, 'active': True} + data = {'user': 6} response = self.client.patch(url, data=data) self.assertEqual(response.status_code, 400) diff --git a/pydis_site/apps/api/viewsets/bot/infraction.py b/pydis_site/apps/api/viewsets/bot/infraction.py index 19b6f2d8..066b296f 100644 --- a/pydis_site/apps/api/viewsets/bot/infraction.py +++ b/pydis_site/apps/api/viewsets/bot/infraction.py @@ -161,6 +161,7 @@ class InfractionViewSet( def partial_update(self, request: HttpRequest, *_args, **_kwargs) -> Response: """Method that handles the nuts and bolts of updating an Infraction.""" instance = self.get_object() + request.data.setdefault("active", True) serializer = self.get_serializer(instance, data=request.data, partial=True) serializer.is_valid(raise_exception=True) serializer.save() -- cgit v1.2.3