From 58a4b5b090f75fd5b91067f67b5924e97d701276 Mon Sep 17 00:00:00 2001 From: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com> Date: Fri, 11 Dec 2020 11:40:24 +0100 Subject: Make sure to always upload PR artifact We need to make sure that we always upload our PR artifact, even if linting/testing fails. As GitHub Actions inserts an implicit "success" status check if you don't add any explicit status checks, this means that we have to include an "always" status check, even if this step has a condition relying on another "always" step. --- .github/workflows/lint-test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows') diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index b75e3b8e..397c2085 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -134,7 +134,7 @@ jobs: # `continue-on-error` conclusion is applied, we use the # `.outcome` value. This step also fails silently. - name: Upload a Build Artifact - if: steps.prepare-artifact.outcome == 'success' + if: always() && steps.prepare-artifact.outcome == 'success' continue-on-error: true uses: actions/upload-artifact@v2 with: -- cgit v1.2.3