aboutsummaryrefslogtreecommitdiffstats
path: root/pydis_site
diff options
context:
space:
mode:
authorGravatar SebastiaanZ <[email protected]>2019-04-28 12:01:50 +0200
committerGravatar SebastiaanZ <[email protected]>2019-04-28 12:01:50 +0200
commit9bd2b6fd16e9867bee8a34661e649ead2aff27c6 (patch)
tree9652d6fb63b1d35b332c6d4e3ed6ad7dc95f2a1b /pydis_site
parentAdding complete test suite for nomination end point (diff)
Changing 'end_nomination' endpoint to 'dismiss'
Diffstat (limited to 'pydis_site')
-rw-r--r--pydis_site/apps/api/tests/test_nominations.py18
-rw-r--r--pydis_site/apps/api/viewsets/bot/nomination.py2
2 files changed, 10 insertions, 10 deletions
diff --git a/pydis_site/apps/api/tests/test_nominations.py b/pydis_site/apps/api/tests/test_nominations.py
index cd6f1a90..ba5ae26a 100644
--- a/pydis_site/apps/api/tests/test_nominations.py
+++ b/pydis_site/apps/api/tests/test_nominations.py
@@ -269,7 +269,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_200_on_valid_end_nomination(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(self.active_nomination.id,),
host='api'
)
@@ -291,7 +291,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_400_on_invalid_field_end_nomination(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(self.active_nomination.id,),
host='api'
)
@@ -306,7 +306,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_400_on_missing_unnominate_reason_end_nomination(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(self.active_nomination.id,),
host='api'
)
@@ -320,7 +320,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_400_on_ending_inactive_nomination(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(self.inactive_nomination.id,),
host='api'
)
@@ -362,7 +362,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_404_on_end_unknown_nomination(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(9999,),
host='api'
)
@@ -433,7 +433,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_405_on_end_nomination_put(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(self.inactive_nomination.id,),
host='api'
)
@@ -446,7 +446,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_405_on_end_nomination_post(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(self.inactive_nomination.id,),
host='api'
)
@@ -459,7 +459,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_405_on_end_nomination_delete(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(self.inactive_nomination.id,),
host='api'
)
@@ -472,7 +472,7 @@ class NominationTests(APISubdomainTestCase):
def test_returns_405_on_end_nomination_get(self):
url = reverse(
- 'bot:nomination-end-nomination',
+ 'bot:nomination-dismiss',
args=(self.inactive_nomination.id,),
host='api'
)
diff --git a/pydis_site/apps/api/viewsets/bot/nomination.py b/pydis_site/apps/api/viewsets/bot/nomination.py
index 888f049e..b42e53ff 100644
--- a/pydis_site/apps/api/viewsets/bot/nomination.py
+++ b/pydis_site/apps/api/viewsets/bot/nomination.py
@@ -194,7 +194,7 @@ class NominationViewSet(CreateModelMixin, RetrieveModelMixin, ListModelMixin, Ge
return Response(serializer.data)
@action(detail=True, methods=['patch'])
- def end_nomination(self, request, pk=None):
+ def dismiss(self, request, pk=None):
"""
DRF action for ending an active nomination.