aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Johannes Christ <[email protected]>2020-01-13 21:14:40 +0100
committerGravatar GitHub <[email protected]>2020-01-13 21:14:40 +0100
commite35529d1c0215ac8d7148c66a786ab8780e1f2e9 (patch)
tree968067e10c1e6255a3ae9672aaf818297f2f5a7a
parentAdding iframe attributes to attribute whitelist (diff)
parentUpdate migration dependency to the latest merged (diff)
Merge pull request #303 from python-discord/bot#549-show-attachments-staff
Show attachments in staff log
-rw-r--r--pydis_site/apps/api/migrations/0049_deletedmessage_attachments.py20
-rw-r--r--pydis_site/apps/api/models/bot/message.py7
-rw-r--r--pydis_site/apps/api/serializers.py3
-rw-r--r--pydis_site/apps/api/tests/test_deleted_messages.py9
-rw-r--r--pydis_site/apps/staff/tests/test_logs_view.py17
-rw-r--r--pydis_site/templates/staff/logs.html5
6 files changed, 57 insertions, 4 deletions
diff --git a/pydis_site/apps/api/migrations/0049_deletedmessage_attachments.py b/pydis_site/apps/api/migrations/0049_deletedmessage_attachments.py
new file mode 100644
index 00000000..31ac239a
--- /dev/null
+++ b/pydis_site/apps/api/migrations/0049_deletedmessage_attachments.py
@@ -0,0 +1,20 @@
+# Generated by Django 2.2.6 on 2019-10-28 17:12
+
+import django.contrib.postgres.fields
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+ dependencies = [
+ ('api', '0049_offensivemessage'),
+ ]
+
+ operations = [
+ migrations.AddField(
+ model_name='deletedmessage',
+ name='attachments',
+ field=django.contrib.postgres.fields.ArrayField(base_field=models.URLField(max_length=512), default=[], blank=True, help_text='Attachments attached to this message.', size=None),
+ preserve_default=False,
+ ),
+ ]
diff --git a/pydis_site/apps/api/models/bot/message.py b/pydis_site/apps/api/models/bot/message.py
index 31316a01..8b18fc9f 100644
--- a/pydis_site/apps/api/models/bot/message.py
+++ b/pydis_site/apps/api/models/bot/message.py
@@ -51,6 +51,13 @@ class Message(ModelReprMixin, models.Model):
),
help_text="Embeds attached to this message."
)
+ attachments = pgfields.ArrayField(
+ models.URLField(
+ max_length=512
+ ),
+ blank=True,
+ help_text="Attachments attached to this message."
+ )
@property
def timestamp(self) -> datetime:
diff --git a/pydis_site/apps/api/serializers.py b/pydis_site/apps/api/serializers.py
index 52a82eac..0d1a4684 100644
--- a/pydis_site/apps/api/serializers.py
+++ b/pydis_site/apps/api/serializers.py
@@ -50,7 +50,8 @@ class DeletedMessageSerializer(ModelSerializer):
fields = (
'id', 'author',
'channel_id', 'content',
- 'embeds', 'deletion_context'
+ 'embeds', 'deletion_context',
+ 'attachments'
)
diff --git a/pydis_site/apps/api/tests/test_deleted_messages.py b/pydis_site/apps/api/tests/test_deleted_messages.py
index d1e9f2f5..b3a8197b 100644
--- a/pydis_site/apps/api/tests/test_deleted_messages.py
+++ b/pydis_site/apps/api/tests/test_deleted_messages.py
@@ -25,14 +25,16 @@ class DeletedMessagesWithoutActorTests(APISubdomainTestCase):
'id': 55,
'channel_id': 5555,
'content': "Terror Billy is a meanie",
- 'embeds': []
+ 'embeds': [],
+ 'attachments': []
},
{
'author': cls.author.id,
'id': 56,
'channel_id': 5555,
'content': "If you purge this, you're evil",
- 'embeds': []
+ 'embeds': [],
+ 'attachments': []
}
]
}
@@ -64,7 +66,8 @@ class DeletedMessagesWithActorTests(APISubdomainTestCase):
'id': 12903,
'channel_id': 1824,
'content': "I hate trailing commas",
- 'embeds': []
+ 'embeds': [],
+ 'attachments': []
},
]
}
diff --git a/pydis_site/apps/staff/tests/test_logs_view.py b/pydis_site/apps/staff/tests/test_logs_view.py
index 32cb6bbf..1415c558 100644
--- a/pydis_site/apps/staff/tests/test_logs_view.py
+++ b/pydis_site/apps/staff/tests/test_logs_view.py
@@ -37,6 +37,7 @@ class TestLogsView(TestCase):
channel_id=1984,
content='<em>I think my tape has run out...</em>',
embeds=[],
+ attachments=[],
deletion_context=cls.deletion_context,
)
@@ -101,6 +102,7 @@ class TestLogsView(TestCase):
channel_id=1984,
content='Does that mean this thing will halt?',
embeds=[cls.embed_one, cls.embed_two],
+ attachments=['https://http.cat/100', 'https://http.cat/402'],
deletion_context=cls.deletion_context,
)
@@ -149,6 +151,21 @@ class TestLogsView(TestCase):
self.assertInHTML(embed_colour_needle.format(colour=embed_one_colour), html_response)
self.assertInHTML(embed_colour_needle.format(colour=embed_two_colour), html_response)
+ def test_if_both_attachments_are_included_html_response(self):
+ url = reverse('logs', host="staff", args=(self.deletion_context.id,))
+ response = self.client.get(url)
+
+ html_response = response.content.decode()
+ attachment_needle = '<img alt="Attachment" class="discord-attachment" src="{url}">'
+ self.assertInHTML(
+ attachment_needle.format(url=self.deleted_message_two.attachments[0]),
+ html_response
+ )
+ self.assertInHTML(
+ attachment_needle.format(url=self.deleted_message_two.attachments[1]),
+ html_response
+ )
+
def test_if_html_in_content_is_properly_escaped(self):
url = reverse('logs', host="staff", args=(self.deletion_context.id,))
response = self.client.get(url)
diff --git a/pydis_site/templates/staff/logs.html b/pydis_site/templates/staff/logs.html
index 9c8ed7d3..a0bfa2a7 100644
--- a/pydis_site/templates/staff/logs.html
+++ b/pydis_site/templates/staff/logs.html
@@ -24,6 +24,11 @@
<div class="discord-message-content">
{{ message.content|linebreaks }}
</div>
+ <div class="discord-message-attachments">
+ {% for attachment in message.attachments %}
+ <img alt="Attachment" class="discord-attachment" src="{{ attachment }}">
+ {% endfor %}
+ </div>
{% for embed in message.embeds %}
<div class="discord-embed is-size-7">
<div class="discord-embed-color" style="background-color: {% if embed.color %}{{ embed.color | hex_colour }}{% else %}#cacbce{% endif %}"></div>