aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Hassan Abouelela <[email protected]>2022-07-24 10:06:47 +0200
committerGravatar Hassan Abouelela <[email protected]>2022-07-24 10:06:47 +0200
commitf16d3b1b1d14cdf0de1e56ae2bc466152e930f34 (patch)
tree61a957e380abab3ecbe5afb50b3acd778daf7b04
parentUse Dataclass For Workflow Run (diff)
Use UTC Time For GitHub API
When reading the created_at time from the GitHub API, it'll be a naive date string with UTC time, so we use that instead of the system's time. Signed-off-by: Hassan Abouelela <[email protected]>
-rw-r--r--pydis_site/apps/api/github_utils.py2
-rw-r--r--pydis_site/apps/api/tests/test_github_utils.py4
2 files changed, 3 insertions, 3 deletions
diff --git a/pydis_site/apps/api/github_utils.py b/pydis_site/apps/api/github_utils.py
index c4ace6b7..7d26b147 100644
--- a/pydis_site/apps/api/github_utils.py
+++ b/pydis_site/apps/api/github_utils.py
@@ -148,7 +148,7 @@ def authorize(owner: str, repo: str) -> httpx.Client:
def check_run_status(run: WorkflowRun) -> str:
"""Check if the provided run has been completed, otherwise raise an exception."""
created_at = datetime.datetime.strptime(run.created_at, ISO_FORMAT_STRING)
- run_time = datetime.datetime.now() - created_at
+ run_time = datetime.datetime.utcnow() - created_at
if run.status != "completed":
if run_time <= MAX_RUN_TIME:
diff --git a/pydis_site/apps/api/tests/test_github_utils.py b/pydis_site/apps/api/tests/test_github_utils.py
index f5e072a9..f642f689 100644
--- a/pydis_site/apps/api/tests/test_github_utils.py
+++ b/pydis_site/apps/api/tests/test_github_utils.py
@@ -49,7 +49,7 @@ class CheckRunTests(unittest.TestCase):
"head_sha": "sha",
"status": "completed",
"conclusion": "success",
- "created_at": datetime.datetime.now().strftime(github_utils.ISO_FORMAT_STRING),
+ "created_at": datetime.datetime.utcnow().strftime(github_utils.ISO_FORMAT_STRING),
"artifacts_url": "url",
}
@@ -73,7 +73,7 @@ class CheckRunTests(unittest.TestCase):
# Set the creation time to well before the MAX_RUN_TIME
# to guarantee the right conclusion
kwargs["created_at"] = (
- datetime.datetime.now() - github_utils.MAX_RUN_TIME - datetime.timedelta(minutes=10)
+ datetime.datetime.utcnow() - github_utils.MAX_RUN_TIME - datetime.timedelta(minutes=10)
).strftime(github_utils.ISO_FORMAT_STRING)
with self.assertRaises(github_utils.RunTimeoutError):