aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Leon Sandøy <[email protected]>2018-07-10 06:46:42 +0000
committerGravatar Leon Sandøy <[email protected]>2018-07-10 06:46:42 +0000
commita24b83857c7a9c0a8ed1e36701205ca6265fd362 (patch)
tree26549f1b27d1d9c5f7fd43ba4eb4c9fd56a45b6d
parentRemove space from end of `JAMMERS_ROLE` id in constants.py (diff)
parentFix duplicate channel names in test. (diff)
Merge branch 'fix-numbers-in-channel-names' into 'master'
Allow numbers in channel names See merge request python-discord/projects/site!17
-rw-r--r--pysite/views/api/bot/off_topic_names.py2
-rw-r--r--tests/test_api_bot_off_topic_names.py14
2 files changed, 14 insertions, 2 deletions
diff --git a/pysite/views/api/bot/off_topic_names.py b/pysite/views/api/bot/off_topic_names.py
index e0871067..f353ab02 100644
--- a/pysite/views/api/bot/off_topic_names.py
+++ b/pysite/views/api/bot/off_topic_names.py
@@ -13,7 +13,7 @@ POST_SCHEMA = Schema({
'name': And(
str,
len,
- lambda name: all(c.isalpha() or c == '-' for c in name),
+ lambda name: all(c.isalnum() or c == '-' for c in name),
str.islower,
lambda name: len(name) <= 96,
error=(
diff --git a/tests/test_api_bot_off_topic_names.py b/tests/test_api_bot_off_topic_names.py
index 4c9c782b..f0d0fe3e 100644
--- a/tests/test_api_bot_off_topic_names.py
+++ b/tests/test_api_bot_off_topic_names.py
@@ -36,7 +36,7 @@ class AddingANameOffTopicEndpointTests(SiteTest):
self.assert200(response)
-class AddingChannelNameToDatabaseEndpointTests(SiteTest):
+class AddingChannelNamesToDatabaseEndpointTests(SiteTest):
"""Tests fetching names from the database with GET."""
CHANNEL_NAME = 'bisks-disks'
@@ -59,6 +59,18 @@ class AddingChannelNameToDatabaseEndpointTests(SiteTest):
self.assertIn(self.CHANNEL_NAME, response.json)
+class AllowsNumbersInNames(SiteTest):
+ """Tests that the site allows names with numbers in them."""
+
+ def test_allows_numbers_in_names(self):
+ response = self.client.post(
+ f'/bot/off-topic-names?name=totallynot42',
+ app.config['API_SUBDOMAIN'],
+ headers=app.config['TEST_HEADER']
+ )
+ self.assert200(response)
+
+
class RandomSampleEndpointTests(SiteTest):
"""Tests fetching random names from the website with GET."""