From ff9abdaad65000ef8b56ed21e58bca2ac227773e Mon Sep 17 00:00:00 2001 From: Hedy Li Date: Thu, 8 Oct 2020 03:36:35 +0000 Subject: refactor if else --- bot/exts/halloween/hacktoberstats.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'bot') diff --git a/bot/exts/halloween/hacktoberstats.py b/bot/exts/halloween/hacktoberstats.py index fc66bfa8..4f4ea122 100644 --- a/bot/exts/halloween/hacktoberstats.py +++ b/bot/exts/halloween/hacktoberstats.py @@ -267,10 +267,9 @@ class HacktoberStats(commands.Cog): # Ignore logging non-existent users or users we do not have permission to see if api_message == GITHUB_NONEXISTENT_USER_MESSAGE: logging.debug(f"No GitHub user found named '{github_username}'") - return else: logging.error(f"GitHub API request for '{github_username}' failed with message: {api_message}") - return + return if jsonresp["total_count"] == 0: # Short circuit if there aren't any PRs -- cgit v1.2.3