From 6ca5753d6d566a82917f92d6f9cd6f2c93f1418b Mon Sep 17 00:00:00 2001 From: Sebastiaan Zeeff Date: Mon, 16 Nov 2020 15:56:46 +0100 Subject: Fix lint errors introduced by persistence removal We ripped some features out of the bot to make the migration to kubernetes easier. However, that process left us with some linting errors that will play up if anyone makes a PR. I've added "noqa" to the valid TODO lines and commented out lines that introduced now unused names or tried to use now undefined names. This should have no influence on the bot, as it does not touch code that is actually being run at the moment. --- bot/exts/evergreen/branding.py | 4 ++-- bot/exts/halloween/candy_collection.py | 6 +++--- bot/exts/halloween/hacktoberstats.py | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) (limited to 'bot') diff --git a/bot/exts/evergreen/branding.py b/bot/exts/evergreen/branding.py index b55c9b14..fa607270 100644 --- a/bot/exts/evergreen/branding.py +++ b/bot/exts/evergreen/branding.py @@ -1,6 +1,6 @@ import asyncio import itertools -import json +# import json import logging import random import typing as t @@ -18,7 +18,7 @@ from bot.seasons import SeasonBase, get_all_seasons, get_current_season, get_sea from bot.utils import human_months from bot.utils.decorators import with_role from bot.utils.exceptions import BrandingError -# TODO: Implement substitute for current volume persistence requirements +# TODO: Implement substitute for current volume persistence requirements # noqa: T000 # from bot.utils.persist import make_persistent log = logging.getLogger(__name__) diff --git a/bot/exts/halloween/candy_collection.py b/bot/exts/halloween/candy_collection.py index 7bdc6ef0..bd0b90cc 100644 --- a/bot/exts/halloween/candy_collection.py +++ b/bot/exts/halloween/candy_collection.py @@ -1,7 +1,7 @@ import json import logging import random -from pathlib import Path +# from pathlib import Path from typing import Union import discord @@ -10,7 +10,7 @@ from discord.ext import commands from bot.constants import Channels, Month from bot.utils.decorators import in_month -# TODO: Implement substitutes for volume-persistent methods. +# TODO: Implement substitutes for volume-persistent methods. # noqa: T000 # from bot.utils.persist import make_persistent log = logging.getLogger(__name__) @@ -39,7 +39,7 @@ class CandyCollection(commands.Cog): def __init__(self, bot: commands.Bot): self.bot = bot - self.json_file = make_persistent(Path("bot", "resources", "halloween", "candy_collection.json")) + # self.json_file = make_persistent(Path("bot", "resources", "halloween", "candy_collection.json")) with self.json_file.open() as fp: candy_data = json.load(fp) diff --git a/bot/exts/halloween/hacktoberstats.py b/bot/exts/halloween/hacktoberstats.py index beff86e3..4fd5c324 100644 --- a/bot/exts/halloween/hacktoberstats.py +++ b/bot/exts/halloween/hacktoberstats.py @@ -3,7 +3,7 @@ import logging import re from collections import Counter from datetime import datetime, timedelta -from pathlib import Path +# from pathlib import Path from typing import List, Tuple, Union import aiohttp @@ -13,7 +13,7 @@ from discord.ext import commands from bot.constants import Channels, Month, Tokens, WHITELISTED_CHANNELS from bot.utils.decorators import in_month, override_in_channel -# TODO: Implement substitutes for volume-persistent methods. +# TODO: Implement substitutes for volume-persistent methods. # noqa: T000 # from bot.utils.persist import make_persistent log = logging.getLogger(__name__) @@ -41,7 +41,7 @@ class HacktoberStats(commands.Cog): def __init__(self, bot: commands.Bot): self.bot = bot - self.link_json = make_persistent(Path("bot", "resources", "halloween", "github_links.json")) + # self.link_json = make_persistent(Path("bot", "resources", "halloween", "github_links.json")) self.linked_accounts = self.load_linked_users() @in_month(Month.SEPTEMBER, Month.OCTOBER, Month.NOVEMBER) -- cgit v1.2.3