From 5feabe642ed5b685c7aa9515bc70ff4ff8b278bc Mon Sep 17 00:00:00 2001 From: kwzrd Date: Sat, 28 Mar 2020 16:33:20 +0100 Subject: Deseasonify: log in `add_cog` rather than in each `setup` The previous system required each extension's `setup` func to log that the cog was loaded. This leads to inconsistent messages all trying to convey the same thing, variable logger names in the output file are difficult to read, and several extensions were not logging at all. By logging directly in the `add_cog` method, we reduce code repetition, ensure consistent format, and remove the responsibility to remember that a log should be made. --- bot/exts/christmas/adventofcode.py | 1 - 1 file changed, 1 deletion(-) (limited to 'bot/exts/christmas/adventofcode.py') diff --git a/bot/exts/christmas/adventofcode.py b/bot/exts/christmas/adventofcode.py index f7590e04..8f7aa13b 100644 --- a/bot/exts/christmas/adventofcode.py +++ b/bot/exts/christmas/adventofcode.py @@ -741,4 +741,3 @@ def _error_embed_helper(title: str, description: str) -> discord.Embed: def setup(bot: commands.Bot) -> None: """Advent of Code Cog load.""" bot.add_cog(AdventOfCode(bot)) - log.info("AdventOfCode cog loaded") -- cgit v1.2.3