From 32a4b6ac1c52381520de9dbf36be7f2f2be95bec Mon Sep 17 00:00:00 2001 From: Chris Date: Wed, 9 Jun 2021 22:24:18 +0100 Subject: Update Github emoji to new icons Github updated their icons, so we should update ours too. Co-authored-by: GDWR --- bot/constants.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'bot/constants.py') diff --git a/bot/constants.py b/bot/constants.py index f7fe216b..798cb950 100644 --- a/bot/constants.py +++ b/bot/constants.py @@ -190,12 +190,14 @@ class Emojis: dice_5 = "<:dice_5:755891608091885627>" dice_6 = "<:dice_6:755891607680843838>" - issue = "<:IssueOpen:629695470327037963>" - issue_closed = "<:IssueClosed:629695470570307614>" - pull_request = "<:PROpen:629695470175780875>" - pull_request_closed = "<:PRClosed:629695470519713818>" - pull_request_draft = "<:PRDraft:829755345425399848>" - merge = "<:PRMerged:629695470570176522>" + # These icons are from Github's repo https://github.com/primer/octicons/ + issue_opened = "<:IssueOpen:852294683731165184>" + issue_closed = "<:IssueClosed:852294683723694140>" + issue_draft = "<:IssueDraft:852294683592884284>" # Not currently used by Github, but here for future. + pull_request_open = "<:PROpen:629695470175780875>" + pull_request_closed = "<:PRClosed:852294683194294304>" + pull_request_draft = "<:PRDraft:852294683861712916>" + pull_request_merge = "<:PRMerged:629695470570176522>" number_emojis = { 1: "\u0031\ufe0f\u20e3", -- cgit v1.2.3 From 07a8f19be4f1178cca26330d68c778717d267415 Mon Sep 17 00:00:00 2001 From: Chris Date: Wed, 9 Jun 2021 23:03:55 +0100 Subject: Update tense of icon constants This is so the name of the constants describe the state in the correct tense Co-authored-by: Numerlor --- bot/constants.py | 4 ++-- bot/exts/evergreen/issues.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'bot/constants.py') diff --git a/bot/constants.py b/bot/constants.py index 798cb950..2c18f6e7 100644 --- a/bot/constants.py +++ b/bot/constants.py @@ -191,13 +191,13 @@ class Emojis: dice_6 = "<:dice_6:755891607680843838>" # These icons are from Github's repo https://github.com/primer/octicons/ - issue_opened = "<:IssueOpen:852294683731165184>" + issue_open = "<:IssueOpen:852294683731165184>" issue_closed = "<:IssueClosed:852294683723694140>" issue_draft = "<:IssueDraft:852294683592884284>" # Not currently used by Github, but here for future. pull_request_open = "<:PROpen:629695470175780875>" pull_request_closed = "<:PRClosed:852294683194294304>" pull_request_draft = "<:PRDraft:852294683861712916>" - pull_request_merge = "<:PRMerged:629695470570176522>" + pull_request_merged = "<:PRMerged:629695470570176522>" number_emojis = { 1: "\u0031\ufe0f\u20e3", diff --git a/bot/exts/evergreen/issues.py b/bot/exts/evergreen/issues.py index da10047e..00810de8 100644 --- a/bot/exts/evergreen/issues.py +++ b/bot/exts/evergreen/issues.py @@ -135,7 +135,7 @@ class Issues(commands.Cog): # need from the initial API call. if "issues" in json_data["html_url"]: if json_data.get("state") == "open": - emoji = Emojis.issue_opened + emoji = Emojis.issue_open else: emoji = Emojis.issue_closed @@ -152,7 +152,7 @@ class Issues(commands.Cog): emoji = Emojis.pull_request_open # When 'merged_at' is not None, this means that the state of the PR is merged elif pull_data["merged_at"] is not None: - emoji = Emojis.pull_request_merge + emoji = Emojis.pull_request_merged else: emoji = Emojis.pull_request_closed -- cgit v1.2.3 From dce6930c8be76c1f236247f41ca55ed07f590147 Mon Sep 17 00:00:00 2001 From: Chris Date: Thu, 10 Jun 2021 18:25:54 +0100 Subject: Add transparent border to new Github octicons --- bot/constants.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'bot/constants.py') diff --git a/bot/constants.py b/bot/constants.py index 2c18f6e7..7bd10b5f 100644 --- a/bot/constants.py +++ b/bot/constants.py @@ -191,13 +191,13 @@ class Emojis: dice_6 = "<:dice_6:755891607680843838>" # These icons are from Github's repo https://github.com/primer/octicons/ - issue_open = "<:IssueOpen:852294683731165184>" - issue_closed = "<:IssueClosed:852294683723694140>" - issue_draft = "<:IssueDraft:852294683592884284>" # Not currently used by Github, but here for future. - pull_request_open = "<:PROpen:629695470175780875>" - pull_request_closed = "<:PRClosed:852294683194294304>" - pull_request_draft = "<:PRDraft:852294683861712916>" - pull_request_merged = "<:PRMerged:629695470570176522>" + issue_open = "<:IssueOpen:852596024777506817>" + issue_closed = "<:IssueClosed:852596024739758081>" + issue_draft = "<:IssueDraft:852596025147523102>" # Not currently used by Github, but here for future. + pull_request_open = "<:PROpen:852596471505223781>" + pull_request_closed = "<:PRClosed:852596024732286976>" + pull_request_draft = "<:PRDraft:852596025045680218>" + pull_request_merged = "<:PRMerged:852596100301193227>" number_emojis = { 1: "\u0031\ufe0f\u20e3", -- cgit v1.2.3