| Commit message (Collapse) | Author | Lines |
|---|
|
|
|
This commit introduces enhanced status embeds for workflow runs that
give more information about run that just ended. An added advantage is
that we can disable the default "give me everything"-setting of GitHub
and fine tune when we want to send embeds.
This allows us to only send an embed for the `lint->build` sequence when
the sequence ends (e.g. in the end when done or after an intermediate
step due to failure/cancellation).
|
|
Unfortunately, an expired session cookie wreaked havoc to our Advent of
Code commands: All commands that relied on leaderboard data failed
because we couldn't refresh our data and the cache had expired.
To mitigate an expired session, I've added a fallback session feature
that enables us to try again with a different session. While it will
issue an error message to inform us to refresh the expired session
cookie, it does mean that the functionality should continue to work in
the mean time.
The fallback session cookie is currently set to my session cookie, using
an environment variable, `AOC_FALLBACK_SESSION`. It is important that
the user connected to the session is a member of all boards and that
it's a fresh session: We don't want our fallback to expire!
At the same time, while a single fallback session works, the AoC website
also does not like too many requests from a single user. That's why
we'll still use a multi-session model under normal circumstances.
To check for expired sessions, I've added a URL check: The Advent of
Code website will silently redirect people with an expired session,
issuing an 200: OK status as usual. The only way to really check for it
is by comparing the final URL in the response object to the URL we set
out to GET. I've added a custom exception to signal such an unexpected
redirect.
Finally, instead of having the commands just break, I've added an
Exception signal that propagates back to the caller. The solution, with
try-except, is a bit hacky and could benefit from an actual error
handler, but I wanted to get things fixed first; polish can be added
later.
|
|
To mitigate problems due to expiring session cookies, I'm currently in
the process of adding support for a fallback cookie. Basically, my
Advent of Code account is a member of *all* leaderboards, which means
that my cookie can be used to fetch all leaderboards as well.
As my session cookie should not expire until after the event, it should
not give us any issues. However, to avoid issues with issuing too many
requests from one session, we should still make sure to set individual
session values regardless of the mitigation.
|
|
We noticed that some entries on our leaderboard had an incorrect star
count attached to their name.
After a bit of digging, @HassanAbouelela discovered that this was caused
by the use of the member's name as the key for the leaderboard
dictionary: If different accounts used the same display name for the
leaderboard, they'd be combined into one glitched score dict.
The fix @HassanAbouelela wrote is to use the member id instead of the
name as the key for the leaderboard. I've changed a few names here and
there, but nothing major.
This commit closes #536
|
|
The daily stats function contained a bug that prevented it from working
correctly. The reason was that I was looking for `int` keys where the
actual keys were strings. I now make sure to create a `str` from the
`int` I get back from `range`.
|
|
I've added support for ignoring scores from specific days. A list of
days to ignore can be provided using the environment variable
`AOC_IGNORED_DAYS` as a comma-separated list.
This example would ignore day 1 and day 23:
AOC_IGNORED_DAYS=1,23
I've also added a helper function to sort the leaderboard not only on
the achieved score, but also on the number of stars an individual has
completed.
|
|
|
|
|
|
Note: This won't start the countdown functions yet, they still rely on
the cog being loaded in december.
|
|
|
|
|
|
I've moved the helper functions to the _helpers.py module and clarified
the docstring of the `is_in_advent` helper function.
|
|
There were still two constants left over that were no longer used after
the rewrite. I've removed them.
|
|
I've updated the information for the about embed:
- Added information on the scoring of private leaderboards
- Changed the text of "join our private leaderboard", as we no longer
have to introduce private leaderboards there.
- I've also streamlined the section on Auth providers.
|
|
I accidentally removed the global leaderboard command. I've added it
back!
|
|
|
|
|
|
We're no longer going to use a two-channel setup for this event, as we
don't want to split the event community into two, staff and non-staff.
|
|
This helper function was only being used in one spot and did not factor
out any logic. I've removed the helper function to just create the embed
where it's needed.
|
|
I've rewritten the Advent of Code leaderboard logic. Unfortunately,
nearly all of the changes made are interrelated, meaning that they've
ended up in the same commit.
To add a bit of structure to the extension, I've chosen for a subpackage
structure instead of a single file structure.
The biggest changes:
- Whether or not you get a join code for the staff leaderboard will now
be determined by looking for the Helpers-role.
- The Python Discord Leaderboard now includes all boards, including the
staff leaderboard. This is one event.
- Redis is now used to set a cache expiry period. This means that our
code does not have to check for cache staleness; Redis will do that
for us.
- The period "fetching" task has been removed. We now fetch solely when
the data is needed to prevent putting unnecessary stress on the Advent
of Code website.
- The option to display the Global Leaderboard within Discord has been
removed. Rather, we now link to the website. This simplified the code
for now, although we could add it back later.
- An additional command, `.aoc refresh`, has been added to allow Admins
and the Events Lead to force the cache to be invalidated. This should
be done sparingly to not overburden the AoC website.
- I've also made sure that the daily notification task actually pings
the notification role by setting the `allowed_mentions` kwarg.
|
|
As the Advent of Code file was getting massive, I've removed the old
single-file based extension as I'm going to replace it with a partially
rewritten subpackage-based extension.
|
|
I've added a unified approach to setting data for multiple leaderboards
using environmental variables. Instead of setting separate variables for
the three pieces of data we have, hoping that the position of each board
matches up in the three fields, I now set one environmental variable,
AOC_LEADERBOARDS, that holds delimited data.
The data is in the format:
board_id1,session1,join_code1::board_id2,session2,join_code2[::...]
The staff leaderboards should be included as usual in this environmental
variable. Another environment variable, AOC_STAFF_LEADERBOARD_ID, can be
used to designate which leaderboard should be used as the staff board.
I've also made some other constants configurable in this commit and
added the role ID of the Events Lead role to allow the Events Lead to
force a reload of the leaderboard cache.
|
|
|
|
|
Joe Banks
Sebastiaan Zeeff
Den4200
Sebastiaan Zeeff
Matteo Bertucci