| Commit message (Collapse) | Author | Lines |
|
Our two workflows, Lint and Build, now have separate status badges that link to the latest results from that workflow.
|
|
I've separated the lint and build jobs into two separate workflows:
- Lint: .github/workflows/lint.yaml
- Build: .github/workflows/build.yaml
The main difference is that the Build workflow will be triggered if the
Lint workflow completes while it's been run on the "master" branch. The
build job will check if the Lint run was successful and if it were, it
actually builds the container, pushes it the GHCR, and triggers the
deployment to our kubernetes cluster.
|
|
We ripped some features out of the bot to make the migration to
kubernetes easier. However, that process left us with some linting
errors that will play up if anyone makes a PR.
I've added "noqa" to the valid TODO lines and commented out lines that
introduced now unused names or tried to use now undefined names. This
should have no influence on the bot, as it does not touch code that is
actually being run at the moment.
|
|
Unfortunately, the flake8 action we were using from the marketplace
required us to use the `pull_request_target` event, which runs in the
context of the target repository to protect secrets.
However, this also meant that flake8 would run on files already merged
into our master branch, not the actual changes made in teh PR! That's
obviously pretty useless as a guard against merging linting errors into
our repository.
This change sidesteps the issue by removing the marketplace action and
replacing it by a direct `flake8` run command. To make sure error output
ends up as a GitHub Actions Annotation, we ask `flake8` to format its
error messages using the correct GitHub Workflow Command format:
::error file={filename},line={line},col={col}::{message}
Whenever something is printed to stdout/stderr in that format, GitHub
Actions will automatically interpret it as the "register error message"
workflow command.
Since this doesn't require a GitHub Token with "write" permissions, we
can now switch back to the safer `pull_request` event that gets a
read-only GitHub Token.
|
|
We're no longer using DockerHub in our deployment for SeasonalBot, so it
does not make sense to keep pushing containers there.
|
|
|
|
|