aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
...
| | | | | * Deseasonify: improve branding embedGravatar kwzrd2020-03-19-15/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This improves both the visual embed, and the code used to generate it. We'll now only display active months if the current season isn't the evergreen - no reason to list the 12 months. The season's name and avatar will be shown in the author field, as this is more less aggressive and more visually pleasing than using title + thumbnail. The embed will be coloured using the season's colour attr. All values have safe fall-backs for situations where the seasonal assets have failed to load.
| | | | | * Deseasonify: turn legacy docstrings into attrsGravatar kwzrd2020-03-19-70/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We no longer use the class docstrings for announcements, and they mostly contain outdated information. Sentences still relevant are used to populate the `description` attr (which shows in the branding embed), the rest is scrapped. The descriptions themselves can still be improved in the future, once we figure out exactly in which direction we want to go with them. The idea of providing a description for each season's branding was originally brought up by neonsea, co-authored below. Co-authored-by: Rasmus Moorats <[email protected]>
| | | | | * Deseasonify: add colour attr to seasonal classesGravatar kwzrd2020-03-19-7/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We'll use this to colour the branding embed, as it currently looks very plain. Seasons can either provide their own, or just use the default green.
| | | | | * Deseasonify: authorize with github tokenGravatar kwzrd2020-03-18-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is not critical that a token is provided, as the target repository is public. However, if a token is provided, let's use it.
| | | | | * Deseasonify: add github token env varGravatar kwzrd2020-03-18-0/+1
| | | | | |
| | | | | * Deseasonify: join paths on newlineGravatar kwzrd2020-03-18-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're now presenting a lot more information (paths vs only filenames previously), so visually this works better.
| | | | | * Deseasonify: extend in-line documentationGravatar kwzrd2020-03-18-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A few extra words about the look-ups being able to fall back on safe values. The comments also introduce extra visual separation between logical steps in the process.
| | | | | * Deseasonify: remove excessive info embed informationGravatar kwzrd2020-03-18-8/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we were showing the entire queue of coming-up icons. As we're now showing full paths (rather than just filenames), this creates a lot of visual clutter that is unnecessary. It's not critical to know in which order the icons will be cycled, as there's no way for us to affect it anyway. This list of all available icons is still displayed above. The information about configured cycle frequency goes in the footer, if we're cycling.
| | | | | * Deseasonify: refer to bot icons as avatarsGravatar kwzrd2020-03-18-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is an annoying collision in the "server icon" vs "bot icon" nomenclature, so I made the decision to always refer to the bot's image as avatar. This choice is already visible through the module, we only need to adjust the actual filename that we're looking for. The filenames will be adjusted in the branding repository.
| | | | | * Deseasonify: make asset filenames module constantsGravatar kwzrd2020-03-18-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | Less error-prone; easier to adjust.
| | | | | * Deseasonify: fallback on evergreen on incomplete brandingGravatar kwzrd2020-03-18-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation would simply ignore assets not present in the current season's directory. On the condition that at least one asset is missing, and the current season is not the evergreen, we also poll the evergreen directory, and use it as fallback. This behaviour is shielded such that we only make the extra API call if there is a missing asset, i.e. if there is something to be gained.
| | | | | * Deseasonify: keep track of `path` on github filesGravatar kwzrd2020-03-18-11/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the banner and avatar assets will always have the same filename, we need their full paths to differentiate between assets of different seasons. Rather than introducing more complexity to the `pretty_files` function and deconstructing the download urls, we can just store the path as provided by the API. We also now print the `path` instead of showing bools in the status embed, as just the fact that there is some banner is not enough information - we want to know which season's banner has been picked up during refresh.
| | | | | * Deseasonify: allow `set` to take multi-word argsGravatar kwzrd2020-03-17-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We do not have any multi-word seasons at the moment, but there is no reason to restrict the command to just one word.
| | | | | * Deseasonify: improve `SeasonBase` docstring wordingGravatar kwzrd2020-03-17-2/+2
| | | | | |
| | | | | * Deseasonify: relax type annotationGravatar kwzrd2020-03-15-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Asyncio's sleep will accept both, and we default to an int, so might as well not break our own promise.
| | | | | * Deseasonify: remove fragile attr dependency in `seasonal_task`Gravatar kwzrd2020-03-15-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Importing the bot instance will allow us to safely access the `wait_until_ready` method without having to make fragile assumptions about the arguments passed to the decorated method. Although still not perfect, this feels a lot cleaner and safer than the previous approach.
| | | | | * Merge branch 'master' into seasonal-purgeGravatar kwzrd2020-03-15-1/+557
| | | | | |\ | |_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This merges the newly added help cog. Resolve slight conflict in the __main__ module caused by the the master branch still assuming the presence of the legacy season manager cog.
* | | | | | Merge pull request #371 from ks129/helpGravatar S. Co12020-03-13-1/+555
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Added Python bot help command to SeasonalBot
| * | | | | Merge branch 'master' into helpGravatar S. Co12020-03-13-452/+917
| |\ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | (Help): Comments CleanupGravatar ks1232020-03-13-13/+0
| | | | | |
| * | | | | (Help): Removed unnecessary comments about changesGravatar ks1232020-03-10-8/+0
| | | | | |
| * | | | | (Help): Added `Icons` class to constant, added `questionmark` to there, ↵Gravatar ks1232020-03-10-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | reverted icon removal in `.help` command.
| * | | | | (Help): Added cog loading to __main__.pyGravatar ks1232020-03-07-0/+1
| | | | | |
| * | | | | (Help): Added unloading block in cogs loadingGravatar ks1232020-03-07-1/+1
| | | | | |
| * | | | | (Help): Made modifications to original code to make this working in ↵Gravatar ks1232020-03-07-10/+26
| | | | | | | | | | | | | | | | | | | | | | | | SeasonalBot, marked them down with comments and fixed docstrings formatting for linting.
| * | | | | (Help): Added information comment to top of fileGravatar ks1232020-03-07-0/+1
| | | | | |
| * | | | | Copy-pasted help command content from Python botGravatar ks1232020-03-07-0/+554
| | |_|/ / | |/| | |
| | | | * Deseasonify: move the branding module from seasons to bot directoryGravatar kwzrd2020-03-15-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | It makes more sense for it to be positioned alongside other core bot features.
| | | | * Deseasonify: apply seasonal task mechanism to tasks as appropriateGravatar kwzrd2020-03-15-21/+6
| | | | |
| | | | * Deseasonify: add convenience decorator for seasonal tasksGravatar kwzrd2020-03-15-0/+39
| | | | | | | | | | | | | | | | | | | | See docstring for implementation details.
| | | | * Deseasonify: season-lock listeners where appropriateGravatar kwzrd2020-03-15-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | We want to prevent listeners from performing season-specific behaviour outside of specific months.
| | | | * Deseasonify: add listener decorator for season lockingGravatar kwzrd2020-03-15-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A guarded listener will abort if the triggering event happens outside of `allowed_months`. This provides a convenient way of season-locking listeners without having to write guards directly within their bodies.
| | | | * Deseasonify: improve `in_month` command checkGravatar kwzrd2020-03-15-4/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Raise a custom exception if the command fails. This is then handled in the error handler, and the user will be informed of which months allow the invoked command.
| | | | * Deseasonify: lock branding commands to moderation rolesGravatar kwzrd2020-03-15-1/+3
| | | | |
| | | | * Deseasonify: use more descriptive name for `Record` namedtupleGravatar kwzrd2020-03-15-15/+15
| | | | |
| | | | * Deseasonify: improve logic in `set` commandGravatar kwzrd2020-03-14-14/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent re-applying branding if the user requests an already active season. This saves us an expensive operation. Only trigger typing if season switch was successful and `apply` will be called, as otherwise the bot will respond immediately.
| | | | * Deseasonify: implement `BrandingManager` cogGravatar kwzrd2020-03-14-0/+312
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provides a background daemon capable of autonomously managing the guild's and bot's branding across seasons. Alternatively, the cog can be manually controlled via the `branding` command group. See docstrings for detailed implementation details. Actual calls to Discord API are commented out and replaced with logs, to prevent API abuse during development.
| | | | * Deseasonify: improve documentation for `icon_cycle_frequency`Gravatar kwzrd2020-03-14-1/+1
| | | | |
| | | | * Deseasonify: add `set_banner` method to SeasonalBotGravatar kwzrd2020-03-14-0/+18
| | | | |
| | | | * Deseasonify: add convenience method to get season by nameGravatar kwzrd2020-03-14-2/+17
| | | | |
| | | | * Deseasonify: add convenience method to get current seasonGravatar kwzrd2020-03-14-2/+22
| | | | |
| | | | * Deseasonify: lock daily tasks to their seasons' respective monthsGravatar kwzrd2020-03-08-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Applies to daily egg facts and pride facts of the day. Currently, we do not have any sophisticated mechanism in place. However, we can simply configure `active_months` for the cog, and then have the task perform a membership check in each cycle.
| | | | * Deseasonify: adjust inheriting seasons in accordance with new systemGravatar kwzrd2020-03-08-66/+26
| | | | | | | | | | | | | | | | | | | | | | | | | Ensure that all inheriting seasons are now providing the right attrs as defined in `SeasonBase`.
| | | | * Deseasonify: remove `Evergreen` seasonGravatar kwzrd2020-03-08-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | The `SeasonBase` now serves as the fallback, off-season season for when no other season is available.
| | | | * Deseasonify: implement `SeasonBase` for new seasonal systemGravatar kwzrd2020-03-08-12/+16
| | | | | | | | | | | | | | | | | | | | See class docstring for implementation details.
| | | | * Deseasonify: allow `get_extensions` to find cogs in `seasons`Gravatar kwzrd2020-03-08-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a conditional check to handle cases where `package` is, in fact, just a plain module, and should be loaded directly rather than being searched for modules. The naming here could be improved: `package` does not necessarily have to be a package.
| | | | * Deseasonify: remove redundant importGravatar kwzrd2020-03-07-2/+0
| | | | |
| | | | * Deseasonify: remove empty season moduleGravatar kwzrd2020-03-07-0/+0
| | | | | | | | | | | | | | | | | | | | The file snuck back in during merge conflict resolve.
| | | | * Deseasonify: create daily tasks inside cog init; wait until readyGravatar kwzrd2020-03-07-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the cog was being instantiated once: once to launch the task, and once to be registered under `bot`. Now, the cog is only created once, and the task is built inside the cog's init. Since cogs are now loaded before the bot connects, the tasks need to wait before the bot's cache is ready, to ensure that the channel is found.
| | | | * Deseasonify: remove reference to non-existent task, redundant attrGravatar kwzrd2020-03-07-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `_fact_publisher_task` task was removed many commits ago, yet the listener still attempts to launch it. There is no need to set the channel instance attr, as it isn't used anywhere. This renders the listener useless, and it can be removed.