aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeLines
* Changed Python language hook to system.Gravatar xithrius2021-01-02-1/+1
|
* Merge pull request #484 from WillDaSilva/omdb-to-tmdbGravatar ks1292020-12-29-51/+51
|\ | | | | Replace OMDB with TMDB
| * Remove unused importGravatar William Da Silva2020-12-29-1/+1
| |
| * Merge branch 'master' into omdb-to-tmdbGravatar William Da Silva2020-12-28-1049/+1262
| |\ | |/ |/|
* | Merge pull request #483 from WillDaSilva/prideavatar-urlGravatar ks1292020-12-28-37/+70
|\ \ | | | | | | Make prideavatar support specifying the image by URL
| * \ Merge branch 'master' into prideavatar-urlGravatar ks1292020-12-28-1014/+1192
| |\ \ | |/ / |/| |
* | | Merge pull request #547 from python-discord/ks123/sentryGravatar ks1292020-12-20-70/+111
|\ \ \ | | | | | | | | Sentry SDK version bump, integrations adding and Sentry release workflow
| * | | Fix wrong way for getting Git SHAGravatar ks1292020-12-20-1/+1
| | | |
| * | | Use sir-lancebot release prefix in workflowGravatar ks1292020-12-19-1/+1
| | | |
| * | | Use sir-lancebot instead pydis-sir-lancebot for release nameGravatar ks1292020-12-19-1/+1
| | | | | | | | | | | | Co-authored-by: Joe Banks <[email protected]>
| * | | Remove aiohttp integration from SentryGravatar ks1292020-12-19-3/+1
| | | |
| * | | Add release tag to Sentry SDK initializationGravatar ks1292020-12-19-3/+4
| | | |
| * | | Add Git SHA as constantGravatar ks1292020-12-19-0/+2
| | | |
| * | | Put Git SHA to container on container buildGravatar ks1292020-12-19-0/+2
| | | |
| * | | Add default development value to Git SHAGravatar ks1292020-12-19-1/+1
| | | |
| * | | Add Git SHA build argument to DockerfileGravatar ks1292020-12-19-1/+5
| | | |
| * | | Create Sentry release workflowGravatar ks1292020-12-19-0/+24
| | | |
| * | | Add Redis and aiohttp integrations to SentryGravatar ks1292020-12-19-1/+7
| | | |
| * | | Bump Sentry SDK from 0.14 to 0.19Gravatar ks1292020-12-19-67/+71
|/ / /
* | | Merge pull request #535 from ↵Gravatar Sebastiaan Zeeff2020-12-16-98/+182
|\ \ \ | | | | | | | | | | | | | | | | python-discord/sebastiaan/advent-of-code/refactor-background-tasks Refactor Advent of Code background tasks to account for deseasonification
| * \ \ Merge branch 'master' into sebastiaan/advent-of-code/refactor-background-tasksGravatar Sebastiaan Zeeff2020-12-16-0/+4
| |\ \ \ | |/ / / |/| | |
* | | | Add codeowner entries for ks129Gravatar ks1292020-12-16-0/+4
| | | |
| * | | Clarify comment on AoC Status Task startup delayGravatar Sebastiaan Zeeff2020-12-13-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Advent of Code Status Countdown task needs to wait for two things to happen to prevent it from failing during the startup sequence: 1. The Websocket instance discord.py creates needs to be available as an attribute of the bot, otherwise discord.py fails internally: Traceback (most recent call last): File "discord/client.py", line 1049, in change_presence await self.ws.change_presence( activity=activity, status=status, afk=afk ) File "advent_of_code/_cog.py", line 52, in countdown_status await bot.change_presence(activity=discord.Game(playing)) AttributeError: 'NoneType' object has no attribute 'change_presence' 2. Allegedly, according to the discord.py community, trying to change the status too early in the sequence to establish a connection with Discord may result ub the Discord API aborting the connection. To solve this, I've added a `wait_until_guild_available` waiter, as it guarantees that the websocket is available and the connections is mature. Kaizen: I've changed the name `new_puzzle_announcement` to `new_puzzle_notification` to better reflect its function.
| * | | Merge branch 'master' into sebastiaan/advent-of-code/refactor-background-tasksGravatar Sebastiaan Zeeff2020-12-13-226/+252
| |\ \ \ | |/ / / |/| | | | | | | | | | | | | | | # Conflicts: # bot/exts/christmas/advent_of_code/_cog.py # bot/exts/christmas/advent_of_code/_helpers.py
* | | | Add callback to log errors in AoC background tasksGravatar Sebastiaan Zeeff2020-12-13-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, our Advent of Code background tasks fail without logging errors or printing error messages. This makes it difficult to debug the errors and means that they may fail silently. While we should ideally find the root cause that hides such errors, I've added a done_callback function in the meantime to help us debug the current issues with the Advent of Code Notification Task.
* | | | Merge pull request #541 from janine9vn/aoc2020Gravatar Boris Muratov2020-12-12-5/+16
|\ \ \ \ | | | | | | | | | | Aoc2020
| * | | | Change AOC_WHITELIST names for clarityGravatar janine9vn2020-12-11-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | AOC_WHITELIST was changed to AOC_WHITELIST_RESTRICTED because it is clearer that commands with this parameter in the `@override_in_channel()` decorator will be restricted to the aoc commands channel and not be allowed in the main aoc channel. In the same vein, AOC_WHITELIST_PLUS was changed to AOC_WHITELIST.
| * | | | Change Default AoC Commands ChannelGravatar janine9vn2020-12-11-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes the default value of the advent_of_code_commands constant to be the same channel ID as sir-lancebot-commands. If no AoC commands channel is set in the .env file, it'll re-direct people to sir-lancebot-commands instead.
| * | | | Remove extra pleaseGravatar janine9vn2020-12-11-1/+1
| | | | | | | | | | | | | | | | | | | | Please -= 1
| * | | | Remove re-raising the errorGravatar janine9vn2020-12-11-2/+0
| | | | | | | | | | | | | | | | | | | | Per Mark's comment, re-raising the error isn't necessary.
| * | | | Change custom error handler to match new styleGravatar janine9vn2020-12-11-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | I'm a bit ahead of the game and changing the error handler to match the new style that Iceman will PR shortly.
| * | | | Add cog-level error handler for Incorrect ChannelGravatar janine9vn2020-12-11-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If any of the "spammier" commands (stats, leaderboard) are used within the primary advent of code channel, rather than a non-specific embed we instead reply with the channel they should be using. This also adds a "AOC_WHITELIST_PLUS" constant that makes it easier to adjust what channels the non-spammier aoc commands can be used in.
| * | | | Disallow .aoc commands in primary aoc channelGravatar janine9vn2020-12-11-5/+6
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commands like `.aoc leaderboard` and `.aoc stats` proved to be spammy in the main advent of code channel. An aoc_commands channel has been added for aoc commands and this update prohibits aoc commands from being used in the primary aoc channel and adds the comands channel to the whitelist. This also specifically allows the less spammier commands: join, subscribe, unsubscribe, and countdown in the primary channel to foster discussion though.
* | | | Merge pull request #540 from RohanJnr/error_handler_changesGravatar Mark2020-12-11-21/+10
|\ \ \ \ | | | | | | | | | | Modify error handler check for locally handled errors.
| * | | | Check if error.original is an instance of OSError.Gravatar Rohan2020-12-11-4/+3
| | | | | | | | | | | | | | | | | | | | Also, remove error handler for get_command and video_command.
| * | | | Modify snakes_cog error handler.Gravatar Rohan2020-12-07-16/+6
| | | | | | | | | | | | | | | | | | | | | | | | | local error handler no longer checks for BadArgument error and the attribute handled will be set to True on the error if an OSError occurs.
| * | | | Check value of handled attribute on error in global error handler.Gravatar Rohan2020-12-04-1/+1
| | | | |
| * | | | Modify error handler check for locally handled errors.Gravatar Rohan2020-12-02-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Error handler now checks if the error has the attribute "handled" for locally handled errors.
* | | | | Make sure PR artifacts are always uploadedGravatar Sebastiaan Zeeff2020-12-11-1/+1
| | | | | | | | | | | | | | | We need to upload PR artifacts regardless of our lint job failing. As GitHub Actions uses an implicit "success" status function if you don't specify one of your own, we need to include the "always" function in our condition.
* | | | | Skip status embed for skipped Build workflowGravatar Sebastiaan Zeeff2020-12-10-2/+3
| | | | | | | | | | | | | | | With the new `workflow_run` setup, we need to make sure that we don't try to send an embed for a skipped workflow. This would be noisy and does not add a lot of useful information.
* | | | | Use Build Artifact to communicate PR informationGravatar Sebastiaan Zeeff2020-12-10-18/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A workflow run with a `workflow_run` payload does not contain the necessary information to build a PR embed. As the old method of using the API to fetch the relevant information turned out to be fragile (read note 1 below) and the original Lint workflow already contains the `pull_request` payload, we now store it as a build artifact. The embed workflow then fetches the artifact and parses it to get the relevant information out of it. --- Note 1: Unfortunately, filtering Pull Requests using the "head" parameter of the ``/repos/{owner}/{repo}/pulls` endpoint does not work if the PR belongs to a fork with a different name than the base repository: the API request will just return an empty array. I've contacted GH to ask if this was intended or if it's a glitch, but, for now, it's not a route that's easily available.
* | | | | Use workflow_run to send status embed to DiscordGravatar Sebastiaan Zeeff2020-12-09-63/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've changed the way we send status embeds to make it work for PRs made from forks without potentially exposing secrets. Instead of using the initial workflows to send the embed, I've created a `workflow_run` workflow that always runs in the context of the base repository. And added benefit is that we don't have to add the status embed step to two separate workflows.
* | | | | Merge pull request #542 from python-discord/sebastiaan/ci/status-embedsGravatar Dennis Pham2020-12-07-0/+63
|\ \ \ \ \ | | | | | | | | | | | | Use custom status embeds for workflow runs
| * \ \ \ \ Merge branch 'master' into sebastiaan/ci/status-embedsGravatar Dennis Pham2020-12-07-166/+3
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Merge pull request #543 from python-discord/update-approval-policiesGravatar Joe Banks2020-12-06-166/+3
|\ \ \ \ \ \
| * | | | | | Create review-policy.ymlGravatar Joe Banks2020-12-06-0/+3
| | | | | | |
| * | | | | | Delete review check GitHub ActionGravatar Joe Banks2020-12-06-166/+0
|/ / / / / /
| * / / / / Use custom status embeds for workflow runsGravatar Sebastiaan Zeeff2020-12-05-0/+63
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit introduces enhanced status embeds for workflow runs that give more information about run that just ended. An added advantage is that we can disable the default "give me everything"-setting of GitHub and fine tune when we want to send embeds. This allows us to only send an embed for the `lint->build` sequence when the sequence ends (e.g. in the end when done or after an intermediate step due to failure/cancellation).
* | | | | Mitigate session expiry by using fallback sessionGravatar Sebastiaan Zeeff2020-12-05-17/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unfortunately, an expired session cookie wreaked havoc to our Advent of Code commands: All commands that relied on leaderboard data failed because we couldn't refresh our data and the cache had expired. To mitigate an expired session, I've added a fallback session feature that enables us to try again with a different session. While it will issue an error message to inform us to refresh the expired session cookie, it does mean that the functionality should continue to work in the mean time. The fallback session cookie is currently set to my session cookie, using an environment variable, `AOC_FALLBACK_SESSION`. It is important that the user connected to the session is a member of all boards and that it's a fresh session: We don't want our fallback to expire! At the same time, while a single fallback session works, the AoC website also does not like too many requests from a single user. That's why we'll still use a multi-session model under normal circumstances. To check for expired sessions, I've added a URL check: The Advent of Code website will silently redirect people with an expired session, issuing an 200: OK status as usual. The only way to really check for it is by comparing the final URL in the response object to the URL we set out to GET. I've added a custom exception to signal such an unexpected redirect. Finally, instead of having the commands just break, I've added an Exception signal that propagates back to the caller. The solution, with try-except, is a bit hacky and could benefit from an actual error handler, but I wanted to get things fixed first; polish can be added later.
* | | | | Support a fallback session cookie in constantsGravatar Sebastiaan Zeeff2020-12-05-2/+20
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To mitigate problems due to expiring session cookies, I'm currently in the process of adding support for a fallback cookie. Basically, my Advent of Code account is a member of *all* leaderboards, which means that my cookie can be used to fetch all leaderboards as well. As my session cookie should not expire until after the event, it should not give us any issues. However, to avoid issues with issuing too many requests from one session, we should still make sure to set individual session values regardless of the mitigation.
generated by cgit v1.2.3 (git 2.39.1) at 2025-10-24 01:04:02 +0000