diff options
| author | 2021-01-26 17:23:30 +0530 | |
|---|---|---|
| committer | 2021-01-26 17:23:30 +0530 | |
| commit | b6cda1a14a2a2e69dac59de675cbea75638c3f64 (patch) | |
| tree | dca961d451b148141cc899a17a3ee96e53216ca7 | |
| parent | Make the python_discord_repos' orgranisation name configurable (diff) | |
Use enums for fetch issue errors.
| -rw-r--r-- | bot/exts/evergreen/issues.py | 15 | 
1 files changed, 11 insertions, 4 deletions
diff --git a/bot/exts/evergreen/issues.py b/bot/exts/evergreen/issues.py index d816770c..bd62fc22 100644 --- a/bot/exts/evergreen/issues.py +++ b/bot/exts/evergreen/issues.py @@ -2,6 +2,7 @@ import logging  import random  import re  import typing as t +from enum import Enum   import discord  from discord.ext import commands, tasks @@ -23,6 +24,12 @@ if GITHUB_TOKEN := Tokens.github:      REQUEST_HEADERS["Authorization"] = f"token {GITHUB_TOKEN}" +class FetchIssueErrors(Enum): +    value_error = "Numbers not found." +    max_requests = "Max requests hit." + + +  class Issues(commands.Cog):      """Cog that allows users to retrieve issues from GitHub.""" @@ -67,10 +74,10 @@ class Issues(commands.Cog):          """Retrieve issue(s) from a GitHub repository."""          links = []          if not numbers: -            return "Numbers not found." +            return FetchIssueErrors.value_error          if len(numbers) > MAX_REQUESTS: -            return "Max requests hit." +            return FetchIssueErrors.max_requests          for number in numbers:              url = f"https://api.github.com/repos/{user}/{repository}/issues/{number}" @@ -137,10 +144,10 @@ class Issues(commands.Cog):          """Command to retrieve issue(s) from a GitHub repository."""          result = await self.fetch_issues(set(numbers), repository, user) -        if result == "Numbers not found.": +        if result == FetchIssueErrors.value_error:              await ctx.invoke(self.bot.get_command('help'), 'issue') -        elif result == "Max requests hit.": +        elif result == FetchIssueErrors.max_requests:              embed = discord.Embed(                  title=random.choice(ERROR_REPLIES),                  color=Colours.soft_red,  |