From a084f79568f2b4808789bb65034e677a4ffdd520 Mon Sep 17 00:00:00 2001 From: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com> Date: Sun, 17 Jan 2021 02:47:07 +0300 Subject: Removes Leading Underscore From Variables Co-authored-by: Joe Banks Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com> --- src/components/Question.tsx | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'src/components/Question.tsx') diff --git a/src/components/Question.tsx b/src/components/Question.tsx index 34d12f7..735d69b 100644 --- a/src/components/Question.tsx +++ b/src/components/Question.tsx @@ -6,7 +6,7 @@ import { Question, QuestionType } from "../api/question"; import { selectable } from "../commonStyles"; import create_input from "./InputTypes"; -const _skip_normal_state: Array = [ +const skip_normal_state: Array = [ QuestionType.Radio, QuestionType.Checkbox, QuestionType.Select, @@ -28,12 +28,12 @@ class RenderedQuestion extends React.Component { this.handler = this.normal_handler.bind(this); } - if (!_skip_normal_state.includes(props.question.type)) { - this._setState("value", ""); + if (!skip_normal_state.includes(props.question.type)) { + this.setPublicState("value", ""); } } - _setState(target: string, value: string | boolean | null, callback?:() => void): void { + setPublicState(target: string, value: string | boolean | null, callback?:() => void): void { this.setState({[target]: value}, callback); this.props.public_state.set(target, value); } @@ -52,7 +52,7 @@ class RenderedQuestion extends React.Component { break; case "radio": - // This handles radios and ranges, as they are both based on the same fundamental input type + // This handles radios and ranges, as they are both based on the same fundamental input type target = "value"; if (event.target.parentElement) { value = event.target.parentElement.innerText.trimEnd(); @@ -66,7 +66,7 @@ class RenderedQuestion extends React.Component { value = event.target.value; } - this._setState(target, value); + this.setPublicState(target, value); // Toggle checkbox class if (event.target.type == "checkbox" && event.target.parentElement !== null) { @@ -76,7 +76,7 @@ class RenderedQuestion extends React.Component { } text_area_handler(event: ChangeEvent): void { - this._setState("value", event.target.value); + this.setPublicState("value", event.target.value); } componentDidMount(): void { @@ -91,14 +91,14 @@ class RenderedQuestion extends React.Component { } options.forEach((option, index) => { - this._setState(`${("000" + index).slice(-4)}. ${option}`, false); + this.setPublicState(`${("000" + index).slice(-4)}. ${option}`, false); }); break; case QuestionType.Range: case QuestionType.Radio: case QuestionType.Select: - this._setState("value", null); + this.setPublicState("value", null); break; } } -- cgit v1.2.3