From 5229c73eeb00e62c2cddb8d3f3939c8a8802e450 Mon Sep 17 00:00:00 2001 From: ks129 <45097959+ks129@users.noreply.github.com> Date: Mon, 14 Dec 2020 17:46:16 +0200 Subject: Improve form responses endpoint --- backend/routes/forms/responses.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/backend/routes/forms/responses.py b/backend/routes/forms/responses.py index 271e8be..ee8ab84 100644 --- a/backend/routes/forms/responses.py +++ b/backend/routes/forms/responses.py @@ -20,11 +20,15 @@ class Responses(Route): @requires(["authenticated", "admin"]) async def get(self, request: Request) -> JSONResponse: """Returns all form responses by form ID.""" + if not await request.state.db.forms.find_one( + {"_id": request.path_params["form_id"]} + ): + return JSONResponse({"error": "not_found"}, 404) + cursor = request.state.db.responses.find( {"form_id": request.path_params["form_id"]} ) - if raw_responses := await cursor.to_list(None): - responses = [FormResponse(**response) for response in raw_responses] - return JSONResponse([response.dict() for response in responses]) - else: - return JSONResponse({"error": "not_found"}, 404) + responses = [ + FormResponse(**response) for response in await cursor.to_list(None) + ] + return JSONResponse([response.dict() for response in responses]) -- cgit v1.2.3