aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGravatar Joe Banks <[email protected]>2025-08-08 23:27:53 +0100
committerGravatar Joe Banks <[email protected]>2025-08-08 23:27:53 +0100
commit9a77782ac0a3b77c75138d1dde5901c9f79a6503 (patch)
tree16c1393125937844ef62fa4ec1276101c92f22c9
parentAdd submission_precheck to public fields list (diff)
Run ruff on codeHEADmain
-rw-r--r--backend/models/form.py6
-rw-r--r--backend/routes/auth/authorize.py2
-rw-r--r--backend/routes/forms/form.py17
-rw-r--r--backend/routes/forms/submit.py5
4 files changed, 20 insertions, 10 deletions
diff --git a/backend/models/form.py b/backend/models/form.py
index 177427c..8250c32 100644
--- a/backend/models/form.py
+++ b/backend/models/form.py
@@ -75,7 +75,11 @@ class Form(BaseModel):
raise ValueError(msg)
if FormFeatures.REQUIRES_LOGIN.value not in value:
- require_login_feature = [FormFeatures.COLLECT_EMAIL, FormFeatures.ASSIGN_ROLE, FormFeatures.UNIQUE_RESPONDER]
+ require_login_feature = [
+ FormFeatures.COLLECT_EMAIL,
+ FormFeatures.ASSIGN_ROLE,
+ FormFeatures.UNIQUE_RESPONDER,
+ ]
for feature in require_login_feature:
if feature.value in value:
diff --git a/backend/routes/auth/authorize.py b/backend/routes/auth/authorize.py
index 7f18cb4..2f9e6e7 100644
--- a/backend/routes/auth/authorize.py
+++ b/backend/routes/auth/authorize.py
@@ -57,7 +57,7 @@ async def process_token(
# Legacy key, we should use exp and use JWT expiry as below it.
"expiry": token_expiry.isoformat(),
# Correct JWT expiry key:
- "exp": token_expiry
+ "exp": token_expiry,
}
token = jwt.encode(data, SECRET_KEY, algorithm="HS256")
diff --git a/backend/routes/forms/form.py b/backend/routes/forms/form.py
index 9414e30..1cd9fde 100644
--- a/backend/routes/forms/form.py
+++ b/backend/routes/forms/form.py
@@ -56,7 +56,9 @@ class SingleForm(Route):
name = "form"
path = "/{form_id:str}"
- @api.validate(resp=Response(HTTP_200=FormWithAncillaryData, HTTP_404=ErrorMessage), tags=["forms"])
+ @api.validate(
+ resp=Response(HTTP_200=FormWithAncillaryData, HTTP_404=ErrorMessage), tags=["forms"]
+ )
async def get(self, request: Request) -> JSONResponse:
"""Returns single form information by ID."""
form_id = request.path_params["form_id"].lower()
@@ -92,21 +94,22 @@ class SingleForm(Route):
form.submission_precheck.problems.append(
SubmissionProblem(
severity=SubmissionPrecheckSeverity.DANGER,
- message="This form is not open for submissions at the moment."
+ message="This form is not open for submissions at the moment.",
)
)
form.submission_precheck.can_submit = False
elif constants.FormFeatures.UNIQUE_RESPONDER.value in form.features:
user_id = request.user.payload["id"] if request.user.is_authenticated else None
if user_id:
- existing_response = await request.state.db.responses.find_one(
- {"form_id": form_id, "user.id": user_id}
- )
+ existing_response = await request.state.db.responses.find_one({
+ "form_id": form_id,
+ "user.id": user_id,
+ })
if existing_response:
form.submission_precheck.problems.append(
SubmissionProblem(
severity=SubmissionPrecheckSeverity.DANGER,
- message="You have already submitted a response to this form."
+ message="You have already submitted a response to this form.",
)
)
form.submission_precheck.can_submit = False
@@ -114,7 +117,7 @@ class SingleForm(Route):
form.submission_precheck.problems.append(
SubmissionProblem(
severity=SubmissionPrecheckSeverity.SECONDARY,
- message="You must login at the bottom of the page before submitting this form."
+ message="You must login at the bottom of the page before submitting this form.",
)
)
diff --git a/backend/routes/forms/submit.py b/backend/routes/forms/submit.py
index 11710fd..036677e 100644
--- a/backend/routes/forms/submit.py
+++ b/backend/routes/forms/submit.py
@@ -182,7 +182,10 @@ class SubmitForm(Route):
)
if existing_response:
return JSONResponse(
- {"error": "unique_responder", "message": "You have already submitted this form."},
+ {
+ "error": "unique_responder",
+ "message": "You have already submitted this form.",
+ },
status_code=400,
)